quark abandoned this revision.
quark added a comment.
In https://phab.mercurial-scm.org/D1044#18824, @durin42 wrote:
> I'm confused what you think the state of this is: the proximate goal of
this series (as I understood it!) was to get run-tests able to restore to an
original revision
durin42 added a comment.
In https://phab.mercurial-scm.org/D1044#18780, @quark wrote:
> I think with `--command`, an option to restore to the original commit is a
useful feature in `bisect` itself. If we cannot reach an agreement before
freeze, could we push the first 3 commits
quark added a comment.
I think with `--command`, an option to restore to the original commit is a
useful feature in `bisect` itself. If we cannot reach agreement, could we push
the first 3 commits
durin42 added a comment.
In https://phab.mercurial-scm.org/D1044#17970, @quark wrote:
> In https://phab.mercurial-scm.org/D1044#17757, @durin42 wrote:
>
> > I'm -0 on the behavior. I'd be indifferent about adding a --abort to
bisect that just is an alias for --reset.
>
>
> What
quark added a subscriber: kulshrax.
quark added a comment.
In https://phab.mercurial-scm.org/D1044#17757, @durin42 wrote:
> I'm -0 on the behavior. I'd be indifferent about adding a --abort to bisect
that just is an alias for --reset.
>
> (I still think it's extremely weird that
durin42 added a comment.
I'm -0 on the behavior. I'd be indifferent about adding a --abort to bisect
that just is an alias for --reset.
(I still think it's extremely weird that ~everyone at Facebook sees bisect as
a modal command like histedit or rebase.)
REPOSITORY
rHG Mercurial
quark added inline comments.
INLINE COMMENTS
> ryanmce wrote in commands.py:809
> I agree. This can be a status or even an info. +1 on the idea of mentioning
> the parent.
rebase uses `ui.warn`. histedit does not have this output. `ui.write` will
cause inconsistency. Maybe it's "safer" to
quark updated this revision to Diff 2705.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1044?vs=2655=2705
REVISION DETAIL
https://phab.mercurial-scm.org/D1044
AFFECTED FILES
mercurial/commands.py
mercurial/hbisect.py
tests/test-bisect-abort.t
ryanmce requested changes to this revision.
ryanmce added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> commands.py:800
> +if firsttime:
> +raise error.Abort(_('not in a bisect'))
> +cmdutil.checkunfinished(repo)
Histedit does
dlax added inline comments.
INLINE COMMENTS
> commands.py:809
> +hbisect.resetstate(repo)
> +ui.warn(_('bisect aborted\n'))
> +return
This "bisect aborted" message is not very useful (especially at "warning"
level): either the command fails with a message or it succeeds
quark updated this revision to Diff 2655.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1044?vs=2648=2655
REVISION DETAIL
https://phab.mercurial-scm.org/D1044
AFFECTED FILES
mercurial/commands.py
mercurial/hbisect.py
tests/test-bisect-abort.t
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Other commands that support a state usually have an `--abort` flag that
restores the repo state to before the state. Let's add a similar one for
bisect. It will
12 matches
Mail list logo
