durin42 added a comment.
Ugh, please send a follow-up, sorry about that.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1070
To: durin42, #hg-reviewers, lothiraldan, indygreg
Cc: indygreg, lothiraldan, morisgi, mercurial-devel
___
lothiraldan added a comment.
Sorry, I was not clear, I was thinking about adding an alias in the config
registration, like that:
coreconfigitem('commands', 'update.check',
default=None,
alias=[('experimental', 'updatecheck')]
)
Should I send a follow-up?
REPOSI
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG23ed47a895d5: config: graduate experimental.updatecheck to
commands.update.check (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.o
durin42 added inline comments.
INLINE COMMENTS
> indygreg wrote in hg.py:761-766
> How do you feel about this alternative approach?
>
> updatecheck = ui.config('commands', 'update.check')
> if updatecheck is None:
> updatecheck = ui.config('experimental', 'updatecheck')
> if updatech
durin42 updated this revision to Diff 2749.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1070?vs=2745&id=2749
REVISION DETAIL
https://phab.mercurial-scm.org/D1070
AFFECTED FILES
mercurial/configitems.py
mercurial/help/config.txt
mercurial/hg.py
indygreg accepted this revision.
indygreg added a comment.
I'm not crazy about the code style. But since this code only lives for a
release, I'm OK taking it. I'll accept this but will defer to someone else to
queue it in case there are strong opinions about the style.
INLINE COMMENTS
> hg.
durin42 marked an inline comment as done.
durin42 added a comment.
Added some docs.
In https://phab.mercurial-scm.org/D1070#17994, @lothiraldan wrote:
> Could you add an alias to `experimental.updatecheck` so old configurations
will not break. I'm not saying to keep it forever but at
durin42 updated this revision to Diff 2745.
durin42 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1070?vs=2727&id=2745
REVISION DETAIL
https://phab.mercurial-scm.org/D1070
AFFECTED FILES
mercurial/configitems.py
lothiraldan requested changes to this revision.
lothiraldan added a comment.
This revision now requires changes to proceed.
Could you add an alias to `experimental.updatecheck` so old configurations
will not break. I'm not saying to keep it forever but at least have it when we
change it.
morisgi added inline comments.
INLINE COMMENTS
> configitems.py:182
> )
> +coreconfigitem('commands', 'update.check',
> +default=None,
Should it be documented in the help then?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1070
To: durin42, #hg-reviewers
Cc
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
No backwards compatibility provided for the legacy name. Perhaps we
should provide that for a release cycle? I don't feel strongly.
REPOSITORY
rHG Mercurial
RE
11 matches
Mail list logo
