This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4fdc4adbc838: templatefilters: defend against evil unicode
strs in json filter (authored by durin42, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D1136?vs=2917=2966#toc
yuja added a comment.
Queued. I've added missed import and dropped r'' from the error message.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1136
To: durin42, #hg-reviewers, yuja
Cc: yuja, ryanmce, mercurial-devel
durin42 updated this revision to Diff 2917.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1136?vs=2886=2917
REVISION DETAIL
https://phab.mercurial-scm.org/D1136
AFFECTED FILES
mercurial/templatefilters.py
CHANGE DETAILS
diff --git
yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ryanmce wrote in templatefilters.py:241-242
> I fear that this is is an non-actionable error. How might I see it as a user?
> If I see it, what do I do?
>
>
ryanmce added a comment.
I'll queue this series except this patch so we can have more discussion on
what we should do here.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1136
To: durin42, #hg-reviewers
Cc: ryanmce, mercurial-devel
ryanmce added a comment.
I'm not a python 3 expert by any means, but I'm not sold on this change.
I think we need perhaps a programming error so it's clear its a bug and not
something the user needs to fix in their command inputs.
INLINE COMMENTS
> templatefilters.py:241-242
> +
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We only want to do I/O in terms of bytes, so lets explode early
instead of recursing forever.
REPOSITORY
rHG Mercurial
REVISION DETAIL
