D1184: fsmonitor: use nonnormalset from dirstatemap

2017-10-19 Thread quark (Jun Wu)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGaf61beb79658: fsmonitor: use nonnormalset from dirstatemap (authored by quark, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1184?vs=3014=3035

D1184: fsmonitor: use nonnormalset from dirstatemap

2017-10-18 Thread wez (Wez Furlong)
wez accepted this revision. wez added a comment. lgtm REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1184 To: quark, #hg-reviewers, wez Cc: wez, mercurial-devel ___ Mercurial-devel mailing list

D1184: fsmonitor: use nonnormalset from dirstatemap

2017-10-18 Thread quark (Jun Wu)
quark updated this revision to Diff 3014. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1184?vs=3013=3014 REVISION DETAIL https://phab.mercurial-scm.org/D1184 AFFECTED FILES hgext/fsmonitor/__init__.py CHANGE DETAILS diff --git

D1184: fsmonitor: use nonnormalset from dirstatemap

2017-10-18 Thread quark (Jun Wu)
quark updated this revision to Diff 3013. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1184?vs=3012=3013 REVISION DETAIL https://phab.mercurial-scm.org/D1184 AFFECTED FILES hgext/fsmonitor/__init__.py CHANGE DETAILS diff --git

D1184: fsmonitor: use nonnormalset from dirstatemap

2017-10-18 Thread quark (Jun Wu)
quark added inline comments. INLINE COMMENTS > wez wrote in __init__.py:416 > ah, I think we do need to keep this code path for the fresh instance case, > otherwise we won't know how to resync with the world Ah, sorry. Will update. REPOSITORY rHG Mercurial REVISION DETAIL

D1184: fsmonitor: use nonnormalset from dirstatemap

2017-10-18 Thread quark (Jun Wu)
quark updated this revision to Diff 3012. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1184?vs=3011=3012 REVISION DETAIL https://phab.mercurial-scm.org/D1184 AFFECTED FILES hgext/fsmonitor/__init__.py CHANGE DETAILS diff --git

D1184: fsmonitor: use nonnormalset from dirstatemap

2017-10-18 Thread wez (Wez Furlong)
wez added inline comments. INLINE COMMENTS > __init__.py:420 > - if (f not in results and > - (st[2] < 0 or st[0] != 'n' or fresh_instance))) > -visit.update(f for f in copymap if f not in results) ... so we should probably restore

D1184: fsmonitor: use nonnormalset from dirstatemap

2017-10-18 Thread wez (Wez Furlong)
wez added inline comments. INLINE COMMENTS > __init__.py:416 > if f not in results and matchfn(f)) > -else: > -if matchalways: ah, I think we do need to keep this code path for the fresh instance case, otherwise we won't know how to resync with the world

D1184: fsmonitor: use nonnormalset from dirstatemap

2017-10-18 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `dirstate._nonnormalset` has been moved to `dirstate._map.nonnormalset` by https://phab.mercurial-scm.org/rHG60927b19ed65c8ec58ec36afc515976b5d17d78a (dirstate: