This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7a58608281dd: remove: print message for each file in
verbose mode only while using `-A` (BC) (authored by pavanpc, committed by ).
CHANGED PRIOR TO COMMIT
yuja accepted this revision.
yuja added a comment.
This revision is now accepted and ready to land.
Queued, thanks. I've added "(BC)" to the commit message.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1336
To: pavanpc, #hg-reviewers, lothiraldan, yuja
Cc:
mitrandir added a comment.
@durin42: I think it should be as good as possible BC-wise. What do you think?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1336
To: pavanpc, #hg-reviewers, lothiraldan, yuja
Cc: yuja, durin42, lothiraldan, mitrandir, mharbison72,
pavanpc added a comment.
@yuja Thank you for your input. Now, warnings are suppressed for the
directory case. Also, I have added test cases for the above cases.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1336
To: pavanpc, #hg-reviewers, lothiraldan, yuja
pavanpc updated this revision to Diff 3621.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1336?vs=3435=3621
REVISION DETAIL
https://phab.mercurial-scm.org/D1336
AFFECTED FILES
mercurial/cmdutil.py
tests/test-remove.t
CHANGE DETAILS
diff --git
yuja added a comment.
In https://phab.mercurial-scm.org/D1336#23872, @pavanpc wrote:
> 4. hg rm -A - What should be the
behavior here? What if the directory has thousands of files . May be we can
suppress warnings based on number of files in the warnings
mharbison72 added a comment.
I guess the other case is when -I PATTERN or -X PATTERN are used instead of
file names. These will be inexact matches like when a directory is specified.
I don’t like the dual behavior controlled by how many files are in the
directory, because the it will seem
mitrandir added a comment.
I think that the cases mentioned by you are right :) In case of directory I'd
prefer so suppress warns. What do you think @yuja ?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1336
To: pavanpc, #hg-reviewers, lothiraldan, yuja
Cc:
pavanpc added a comment.
@yuja @mitrandir
I can think of below cases. Could you please check and let me know your
thoughts on these?
1. hg rm -A- suppress warnings
2. hg rm -Av - do not suppress warnings
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
In https://phab.mercurial-scm.org/D1336#23145, @mitrandir wrote:
> @durin42: I'd say that listing *all the files in the repo* when you run `hg
rm -A` should be considered a bug.
mitrandir added a comment.
@durin42: I'd say that listing *all the files in the repo* when you run `hg
rm -A` should be considered a bug. This can't possibly be the intended
behavior. Also: running `hg rm -A` without a `file` argument is not even
covered by any testcase.
REPOSITORY
rHG
mharbison72 added a comment.
If this can't be taken as-is, what about something in tweakdefaults to hide
this by default? I just assumed that --quiet already worked, and the problem
was that this throws away the other more useful warnings in the non --after
case. (Or people don't remember
durin42 added a comment.
I think this probably violates our BC policy. We could probably stand to add
a `--quiet` for suppressing this output, I suppose.
I'll leave this open for other reviewers to mull over, and if it's still open
in a week without comment I'll probably pass final
lothiraldan accepted this revision.
lothiraldan added a comment.
In https://phab.mercurial-scm.org/D1336#22841, @pavanpc wrote:
> @lothiraldan I modified a test case for hg rm -A case where we
get the message 'not removing : file still exists' . For other cases,
test cases already
pavanpc added a comment.
@lothiraldan I modified a test case for hg rm -A case where we
get the message 'not removing : file still exists' . For other cases,
test cases already exist with 'hg rm -A' and 'hg rm --after' without verbose
mode.
INLINE COMMENTS
> mharbison72 wrote in
pavanpc updated this revision to Diff 3435.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1336?vs=3424=3435
REVISION DETAIL
https://phab.mercurial-scm.org/D1336
AFFECTED FILES
mercurial/cmdutil.py
tests/test-remove.t
CHANGE DETAILS
diff --git
lothiraldan added a comment.
Could we have a test for `hg rm -A` without the verbose mode?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1336
To: pavanpc, #hg-reviewers
Cc: lothiraldan, mitrandir, mharbison72, mercurial-devel
mharbison72 added a comment.
Looks good to me, thanks.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1336
To: pavanpc, #hg-reviewers
Cc: mitrandir, mharbison72, mercurial-devel
___
Mercurial-devel mailing list
pavanpc updated this revision to Diff 3424.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1336?vs=3423=3424
REVISION DETAIL
https://phab.mercurial-scm.org/D1336
AFFECTED FILES
mercurial/cmdutil.py
tests/test-remove.t
CHANGE DETAILS
diff --git
pavanpc updated this revision to Diff 3423.
pavanpc marked an inline comment as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1336?vs=3391=3423
REVISION DETAIL
https://phab.mercurial-scm.org/D1336
AFFECTED FILES
mercurial/cmdutil.py
mharbison72 added a comment.
@pavanpc Looks pretty good- just a few things that popped up in the last
revision.
INLINE COMMENTS
> cmdutil.py:2982
> +ui.progress(_('skipping'), None)
> +ret = 1
> else:
This will need to be protected by seeing if there are any files
21 matches
Mail list logo
