lothiraldan added a comment.
I've resent as https://phab.mercurial-scm.org/D1700 because I couldn't get
phabsend to reproduce my linear updated stack on phabricator :(
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1426
To: lothiraldan, #hg-reviewers, mbthomas
lothiraldan added a comment.
It works when passing `CREATE_NEW_CONSOLE` instead of `DETACHED_PROCESS |
CREATE_NEW_PROCESS_GROUP`.
My concern now is about changing the behavior, do we want to keep the
improvement under a config knob.
REPOSITORY
rHG Mercurial
REVISION DETAIL
mharbison72 added a comment.
Sorry, I'm not sure what the context is here. Is this all to resolve %FOO%
type variables? I don't know of any library to do this either.
Earlier this year I tried fixing the logtoprocess test, which was leaving out
chunks of output on Windows. The only
yuja added a subscriber: mharbison72.
yuja added a comment.
In https://phab.mercurial-scm.org/D1426#28695, @lothiraldan wrote:
> Without `DETACHED_PROCESS`, no console is spawned either with `shell=False`
or `shell=True` **but** Mercurial will wait for the log-to-process script to
lothiraldan added a comment.
Without `DETACHED_PROCESS`, no console is spawned either with `shell=False`
or `shell=True` **but** Mercurial will wait for the log-to-process script to
finish before ending.
So I would say to keep `DETACHED_PROCESS`.
The real question is how to do
lothiraldan added a comment.
I've access to a Windows machine this week, so you can expect a comment or
new version before the end of the week.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1426
To: lothiraldan, #hg-reviewers, mbthomas
Cc: durin42, yuja,
durin42 added a comment.
Boris, any updates on this?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1426
To: lothiraldan, #hg-reviewers, mbthomas
Cc: durin42, yuja, mbthomas, mercurial-devel
___
Mercurial-devel
yuja added a comment.
Do you think `DETACH_PROCESS` should remain specified? I believe that's
the source of the problem, but I can't say it's unnecessary with my little
Windows-fu.
What I know is our `win32.spawndetached()` sets only `CREATE_NO_WINDOW`.
REPOSITORY
rHG Mercurial
lothiraldan updated this revision to Diff 3914.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1426?vs=3528=3914
REVISION DETAIL
https://phab.mercurial-scm.org/D1426
AFFECTED FILES
hgext/logtoprocess.py
mercurial/configitems.py
CHANGE DETAILS
lothiraldan added a comment.
>>> `shell=False` also disables envar expansion, and I guess there would
>>> be lots of trivial behavior changes.
>>
>> I'm not sure to understand what you mean, I tried this configuration:
>>
>> [logtoprocess]
>> commandfinish =
yuja added a comment.
In https://phab.mercurial-scm.org/D1426#23803, @lothiraldan wrote:
> In https://phab.mercurial-scm.org/D1426#23797, @yuja wrote:
>
> > Can't we use `openflags=CREATE_NO_WINDOW` instead?
> >
> > https://stackoverflow.com/a/7006424
>
>
> I tried lots of
lothiraldan added a comment.
In https://phab.mercurial-scm.org/D1426#23797, @yuja wrote:
> Can't we use `openflags=CREATE_NO_WINDOW` instead?
>
> https://stackoverflow.com/a/7006424
I tried lots of things including openflags=CREATE_NO_WINDOW that didn't seem
to work,
yuja added a comment.
Can't we use `openflags=CREATE_NO_WINDOW` instead?
https://stackoverflow.com/a/7006424
`shell=False` also disables envar expansion, and I guess there would
be lots of trivial behavior changes.
REPOSITORY
rHG Mercurial
REVISION DETAIL
lothiraldan added inline comments.
INLINE COMMENTS
> mbthomas wrote in logtoprocess.py:65
> On unix systems `shell=False` means the command provided cannot take any
> arguments, as it's the shell that does the argument splitting. I am guessing
> that this is OK, as we'll just never configure
mbthomas accepted this revision.
mbthomas added inline comments.
INLINE COMMENTS
> logtoprocess.py:65
> subprocess.Popen(
> -script, shell=True, env=env, close_fds=True,
> +script, shell=shell, env=env, close_fds=True,
>
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Starting a shell on Windows means starting a console GUI window in almost all
cases. If we add a logtoprocess for commandfinish and the prompt do some hg
16 matches
Mail list logo
