D1719: debug: remove an 'if ui.debug()' that is not doing anything

2017-12-21 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3bb1a647ab42: debug: remove an if ui.debug() that is not doing anything (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1719: debug: remove an 'if ui.debug()' that is not doing anything

2017-12-21 Thread krbullock (Kevin Bullock)
krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. Seems reasonable. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1719 To: spectral, #hg-reviewers, krbullock Cc: krbullock, quark, mercurial-devel

D1719: debug: remove an 'if ui.debug()' that is not doing anything

2017-12-18 Thread spectral (Kyle Lippincott)
spectral added a comment. In https://phab.mercurial-scm.org/D1719#29390, @quark wrote: > I think it should be `ui.debugflag`. I agree that's probably what was intended, but is it helpful to have it if it's never once been activated in 5 years? (added:

D1719: debug: remove an 'if ui.debug()' that is not doing anything

2017-12-18 Thread quark (Jun Wu)
quark added a comment. I think it should be `ui.debugflag`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1719 To: spectral, #hg-reviewers Cc: quark, mercurial-devel ___ Mercurial-devel mailing list

D1719: debug: remove an 'if ui.debug()' that is not doing anything

2017-12-18 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY ui.debug() does not return a value. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1719 AFFECTED FILES