This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4397909f82d3: phabricator: specify API tokens per host,
rather than per repo (authored by tom.prince, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added a comment.
(If people are happy enough with that, I'll plan to mail my follow-up as a
patch stacked on this one so they can be landed as a pair.)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1919
To: tom.prince, #hg-reviewers, durin42
Cc:
durin42 added a comment.
Coming back to this. How about we do this:
diff --git a/contrib/phabricator.py b/contrib/phabricator.py
--- a/contrib/phabricator.py
+++ b/contrib/phabricator.py
@@ -99,6 +99,17 @@ def urlencodenested(params):
process('', params)
durin42 added a comment.
I generally agree we should support a non-arc option, I'm happy to not have
arc on my machines anymore.
I'll meditate on this over the long weekend.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1919
To: tom.prince,
tom.prince added a comment.
Personally, I don't have arc installed, so I'd prefer putting the auth
information in mercurial rather than arc specific places (this is what is
stored in `.arcrc` I think). It would make sense to support `.arcrc` as well,
though.
It would make sense to read
quark added a comment.
In https://phab.mercurial-scm.org/D1919#37546, @durin42 wrote:
> Sorry, this slipped through the cracks. If we think we want to start
reading .arcconfig, should we just go straight to that and discard our own auth
config area, and incur a BC only once?
One
durin42 added a comment.
Sorry, this slipped through the cracks. If we think we want to start reading
.arcconfig, should we just go straight to that and discard our own auth config
area, and incur a BC only once?
REPOSITORY
rHG Mercurial
REVISION DETAIL
quark added a comment.
> Another thing to consider is reading things from .arcconfig files and
reading the API token however Arcanist does it (as the comment in this file
suggests).
That was my original plan - in `readurltoken`, fallback to `~/.arcrc` and
`.arcconfig` if hgrc does not
indygreg added a comment.
In https://phab.mercurial-scm.org/D1919#33519, @durin42 wrote:
> In https://phab.mercurial-scm.org/D1919#33517, @indygreg wrote:
>
> > FWIW Mozilla will likely start leaning on this extension pretty soon.
Look for a push from us to move it to core before the
durin42 added a comment.
In https://phab.mercurial-scm.org/D1919#33517, @indygreg wrote:
> FWIW Mozilla will likely start leaning on this extension pretty soon. Look
for a push from us to move it to core before the next release.
I've had a...slightly bonkers idea around using
indygreg added a comment.
In https://phab.mercurial-scm.org/D1919#33462, @durin42 wrote:
> I like this, and I'm fine with the backwards incompatible change in
contrib. How do others feel?
I'm fine with BC in contrib.
One thing to bikeshed is if the `[phabricator]` section is
durin42 accepted this revision as: durin42.
durin42 added a comment.
I like this, and I'm fine with the backwards incompatible change in contrib.
How do others feel?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1919
To: tom.prince, #hg-reviewers, durin42
Cc:
durin42 added a comment.
In https://phab.mercurial-scm.org/D1919#32356, @tom.prince wrote:
> I'm not sure what the compatibility policy for `contrib/` files is. This
just *changes* the format for auth data, but it wouldn't be hard to support the
old format too.
I'm not inclined
pulkit added a comment.
Hey, the code freeze for new release of Mercurial started last night. We only
accept bug fixes during code freeze, so this has to wait till 1st feb. Refer:
https://www.mercurial-scm.org/wiki/TimeBasedReleasePlan#Code_Freeze
REPOSITORY
rHG Mercurial
REVISION DETAIL
tom.prince added a comment.
I'm not sure what the compatibility policy for `contrib/` files is. This just
*changes* the format for auth data, but it wouldn't be hard to support the old
format too.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1919
To:
tom.prince created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1919
AFFECTED FILES
contrib/phabricator.py
CHANGE DETAILS
diff --git a/contrib/phabricator.py
16 matches
Mail list logo
