This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd031609b3cb7: changegroup: do not delta lfs revisions
(authored by quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2067?vs=6469=6670
quark added inline comments.
INLINE COMMENTS
> indygreg wrote in test-lfs.t:374
> Where did this change come from?
The number grows from 3 digits to 4 digits because of increased size, and one
of the space becomes a digit.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg accepted this revision.
indygreg added inline comments.
INLINE COMMENTS
> test-lfs.t:374
> * (manifests) (glob)
> - * a (glob)
> + * a (glob)
>$ hg --config extensions.strip= strip -r 2 --no-backup --force -q
Where did this change come from?
REPOSITORY
rHG
quark updated this revision to Diff 6469.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2067?vs=5650=6469
REVISION DETAIL
https://phab.mercurial-scm.org/D2067
AFFECTED FILES
mercurial/changegroup.py
mercurial/revlog.py
tests/test-lfs-bundle.t
quark added inline comments.
INLINE COMMENTS
> ryanmce wrote in revlog.py:746
> `prev` should be `baserev`?
Should be `baserev`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2067
To: quark, indygreg, #hg-reviewers, ryanmce
Cc: martinvonz, durin42,
ryanmce added inline comments.
INLINE COMMENTS
> revlog.py:746
> +def candelta(self, baserev, rev):
> +"""whether two revisions (prev, rev) can be delta-ed or not"""
> +# Disable delta if either rev requires a content-changing flag
`prev` should be `baserev`?
REPOSITORY
quark updated this revision to Diff 5650.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2067?vs=5327=5650
REVISION DETAIL
https://phab.mercurial-scm.org/D2067
AFFECTED FILES
mercurial/changegroup.py
mercurial/revlog.py
tests/test-lfs-bundle.t
martinvonz added a comment.
In https://phab.mercurial-scm.org/D2067#34758, @indygreg wrote:
> This looks mostly good. I would like a change to address a future footgun
though.
>
> I would also appreciate someone familiar with censor and narrow to weigh in
on the implications of
durin42 added a comment.
In https://phab.mercurial-scm.org/D2067#34758, @indygreg wrote:
> This looks mostly good. I would like a change to address a future footgun
though.
>
> I would also appreciate someone familiar with censor and narrow to weigh in
on the implications of
quark updated this revision to Diff 5327.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2067?vs=5273=5327
REVISION DETAIL
https://phab.mercurial-scm.org/D2067
AFFECTED FILES
mercurial/changegroup.py
mercurial/revlog.py
tests/test-lfs-bundle.t
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
This looks mostly good. I would like a change to address a future footgun
though.
I would also appreciate someone familiar with censor and narrow to weigh in
on the
quark updated this revision to Diff 5273.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2067?vs=5269=5273
REVISION DETAIL
https://phab.mercurial-scm.org/D2067
AFFECTED FILES
mercurial/changegroup.py
mercurial/revlog.py
tests/test-lfs-bundle.t
quark updated this revision to Diff 5269.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2067?vs=5264=5269
REVISION DETAIL
https://phab.mercurial-scm.org/D2067
AFFECTED FILES
mercurial/changegroup.py
mercurial/revlog.py
tests/test-lfs-bundle.t
quark created this revision.
Herald added a reviewer: indygreg.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
There is no way to distinguish whether a delta base is LFS or non-LFS.
If the delta is against LFS rawtext, and the client
14 matches
Mail list logo
