D2462: util: add a file object proxy that can notify observers

2018-03-01 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG72c27b55928c: util: add a file object proxy that can notify observers (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2462: util: add a file object proxy that can notify observers

2018-02-27 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > lothiraldan wrote in util.py:535 > Could we define the `ours` set at the class level so an extension/subclass > could easily update it if needed? That's a good idea. I can do it as a follow-up. There are already a ton of commits in this series

D2462: util: add a file object proxy that can notify observers

2018-02-27 Thread lothiraldan (Boris Feld)
lothiraldan added inline comments. INLINE COMMENTS > util.py:535 > +# write defined above > +} > + Could we define the `ours` set at the class level so an extension/subclass could easily update it if needed? REPOSITORY rHG Mercurial REVISION DETAIL

D2462: util: add a file object proxy that can notify observers

2018-02-26 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are various places in Mercurial where we may want to instrument low-level I/O. The use cases I can think of all involve development-type activities like