This revision was automatically updated to reflect the committed changes.
Closed by commit rHG143219fc2620: debugcommands: introduce actions to perform
deterministic reads (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
mharbison72 added a comment.
Sounds good to me. I think the only thing I have inflight is the patch with
explicit flushes in the observer. I haven't tried Yuya's series yet, because
I'm not sure where it fits into the other stuff inflight. I don't mind mopping
this up after it lands.
indygreg added a subscriber: yuja.
indygreg added a comment.
I removed the test changes from this. So we should be able to land it without
causing chaos to Windows tests. It may conflict with other patches that @yuja
and @mharbison72 have in flight though.
REPOSITORY
rHG Mercurial
indygreg updated this revision to Diff 6976.
indygreg edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2720?vs=6714=6976
REVISION DETAIL
https://phab.mercurial-scm.org/D2720
AFFECTED FILES
mercurial/debugcommands.py
indygreg added a comment.
See the `contrib/showstack.py` extension for registering SIGQUIT and SIGINFO
signals to dump the active stack. Not sure if that works on Windows though.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2720
To: indygreg, #hg-reviewers
mharbison72 added a comment.
At this point, I've narrowed it down to stderr. I misunderstood the
'noreadstderr', and wondered why we were bothering to pipe stderr if True. So
I set it to os.devnull, and the test sails through. (But it does drop all "e>"
lines, so that's not an actual
mharbison72 added a comment.
> IDK if this means anything, but when it is stuck and I hit Ctrl+C, instead
of terminating the test, the test simply continues with the script, and then
hangs on the next 'remote output:' line. Typically, Ctrl+C ends the test
runner.
A couple of
mharbison72 added a comment.
In https://phab.mercurial-scm.org/D2720#44396, @indygreg wrote:
> My only explanation is this is stdout output buffering and things are
really hanging on the next read operation.
>
> Maybe try sprinkling some `ui.fout.flush()` and/or `util.stdout.flush()`
indygreg added a comment.
My only explanation is this is stdout output buffering and things are really
hanging on the next read operation.
Maybe try sprinkling some `ui.fout.flush()` and/or `util.stdout.flush()`
and/or `sys.stdout.flush()` calls throughout the debug command? Maybe at
mharbison72 added a comment.
In https://phab.mercurial-scm.org/D2720#44350, @indygreg wrote:
> In https://phab.mercurial-scm.org/D2720#44293, @mharbison72 wrote:
>
> > i> write(4) -> 4:
> > i> 426\n
> > i> write(426) -> 426:
> > i>
indygreg added a comment.
In https://phab.mercurial-scm.org/D2720#44293, @mharbison72 wrote:
> i> write(4) -> 4:
> i> 426\n
> i> write(426) -> 426:
> i>
HG10UN\x00\x00\x00\x9eh\x98b\x13\xbdD\x85\xeaQS55\xe3\xfc\x9ex\x00zq\x1f\x00\x00\x00\x00\x00\x00\x00\x0
>
mharbison72 added a comment.
In https://phab.mercurial-scm.org/D2720#44288, @indygreg wrote:
> In https://phab.mercurial-scm.org/D2720#44221, @mharbison72 wrote:
>
> > This patch seems to deadlock on Windows when running
test-ssh-proto-unbundle.t. There are two python processes
indygreg added a comment.
In https://phab.mercurial-scm.org/D2720#44221, @mharbison72 wrote:
> This patch seems to deadlock on Windows when running
test-ssh-proto-unbundle.t. There are two python processes idling:
>
> Past experience says that something needs to be flushed- stdout
mharbison72 added a comment.
This patch seems to deadlock on Windows when running
test-ssh-proto-unbundle.t. There are two python processes idling:
c:\Python27\python.exe c:/Users/Matt/projects/hg/hg --verbose debugwireproto
--localssh --noreadstderr
CWD:
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
"readavailable" is useful as a debugging device to see what data is
available on a pipe. But the mechanism isn't deterministic because
what's available on a
15 matches
Mail list logo