indygreg added a comment.
I also fixed this in flight to make the import in `__init__.py` relative.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2752
To: pulkit, #hg-reviewers, indygreg
Cc: martinvonz, alex_gaynor, indygreg, mercurial-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7723e2e8cd61: cbor: add a __init__.py to top level cbor
module (authored by pulkit, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D2752?vs=6758=7293#toc
REPOSITORY
rHG
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I vendored upstream commit 84181540f6eb650437e3f73cd104a65661fe8e67. So the
relative imports will drop from this commit when it is pushed.
REPOSITORY
rHG Mercurial
REVISION DETAIL
martinvonz added a comment.
In https://phab.mercurial-scm.org/D2752#45926, @pulkit wrote:
> In https://phab.mercurial-scm.org/D2752#44289, @indygreg wrote:
>
> > I think you should send the relative import patches to upstream. Adding
`from __future__ import absolute_import` would
indygreg added a comment.
In https://phab.mercurial-scm.org/D2752#47301, @alex_gaynor wrote:
> In https://phab.mercurial-scm.org/D2752#47299, @indygreg wrote:
>
> >
>
>
> An intermediate step might be starting a thread on python-dev (or maybe
python-ideas) about it.
alex_gaynor added a comment.
In https://phab.mercurial-scm.org/D2752#47299, @indygreg wrote:
> @alex_gaynor: if I wanted to convince some heavy hitters in the Python
community that relative imports within packages should be a best practice, how
would you recommend going about that?
indygreg added a subscriber: alex_gaynor.
indygreg added a comment.
In https://phab.mercurial-scm.org/D2752#45926, @pulkit wrote:
> In https://phab.mercurial-scm.org/D2752#44289, @indygreg wrote:
>
> > I think you should send the relative import patches to upstream. Adding
`from
pulkit added a comment.
In https://phab.mercurial-scm.org/D2752#44289, @indygreg wrote:
> I think you should send the relative import patches to upstream. Adding
`from __future__ import absolute_import` would also be a nice touch.
I tried that at
indygreg added a comment.
I think you should send the relative import patches to upstream. Adding `from
__future__ import absolute_import` would also be a nice touch.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2752
To: pulkit, #hg-reviewers
Cc: indygreg,
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch also fixes import in cbor2/ to make them relative.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2752
AFFECTED FILES
10 matches
Mail list logo