D2752: cbor: add a __init__.py to top level cbor module

2018-03-26 Thread indygreg (Gregory Szorc)
indygreg added a comment. I also fixed this in flight to make the import in `__init__.py` relative. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2752 To: pulkit, #hg-reviewers, indygreg Cc: martinvonz, alex_gaynor, indygreg, mercurial-devel

D2752: cbor: add a __init__.py to top level cbor module

2018-03-26 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7723e2e8cd61: cbor: add a __init__.py to top level cbor module (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2752?vs=6758=7293#toc REPOSITORY rHG

D2752: cbor: add a __init__.py to top level cbor module

2018-03-26 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. I vendored upstream commit 84181540f6eb650437e3f73cd104a65661fe8e67. So the relative imports will drop from this commit when it is pushed. REPOSITORY rHG Mercurial REVISION DETAIL

D2752: cbor: add a __init__.py to top level cbor module

2018-03-24 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2752#45926, @pulkit wrote: > In https://phab.mercurial-scm.org/D2752#44289, @indygreg wrote: > > > I think you should send the relative import patches to upstream. Adding `from __future__ import absolute_import` would

D2752: cbor: add a __init__.py to top level cbor module

2018-03-23 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D2752#47301, @alex_gaynor wrote: > In https://phab.mercurial-scm.org/D2752#47299, @indygreg wrote: > > > > > > An intermediate step might be starting a thread on python-dev (or maybe python-ideas) about it.

D2752: cbor: add a __init__.py to top level cbor module

2018-03-22 Thread alex_gaynor (Alex Gaynor)
alex_gaynor added a comment. In https://phab.mercurial-scm.org/D2752#47299, @indygreg wrote: > @alex_gaynor: if I wanted to convince some heavy hitters in the Python community that relative imports within packages should be a best practice, how would you recommend going about that?

D2752: cbor: add a __init__.py to top level cbor module

2018-03-22 Thread indygreg (Gregory Szorc)
indygreg added a subscriber: alex_gaynor. indygreg added a comment. In https://phab.mercurial-scm.org/D2752#45926, @pulkit wrote: > In https://phab.mercurial-scm.org/D2752#44289, @indygreg wrote: > > > I think you should send the relative import patches to upstream. Adding `from

D2752: cbor: add a __init__.py to top level cbor module

2018-03-14 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D2752#44289, @indygreg wrote: > I think you should send the relative import patches to upstream. Adding `from __future__ import absolute_import` would also be a nice touch. I tried that at

D2752: cbor: add a __init__.py to top level cbor module

2018-03-09 Thread indygreg (Gregory Szorc)
indygreg added a comment. I think you should send the relative import patches to upstream. Adding `from __future__ import absolute_import` would also be a nice touch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2752 To: pulkit, #hg-reviewers Cc: indygreg,

D2752: cbor: add a __init__.py to top level cbor module

2018-03-09 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch also fixes import in cbor2/ to make them relative. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2752 AFFECTED FILES