yuja added inline comments.
INLINE COMMENTS
> wireprotoserver.py:284
> +res.headers[b'Content-Type'] = b'text/plain'
> +res.setbodybytes(_('HTTP version 2 API handler'))
> +return
Just a nit: No `_()` is needed because we don't know client language nor
character
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGfddcb51b5084: wireproto: define permissions-based routing
of HTTPv2 wire protocol (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg updated this revision to Diff 7195.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2836?vs=7135=7195
REVISION DETAIL
https://phab.mercurial-scm.org/D2836
AFFECTED FILES
mercurial/debugcommands.py
mercurial/help/internals/wireprotocol.txt
indygreg updated this revision to Diff 7135.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2836?vs=7014=7135
REVISION DETAIL
https://phab.mercurial-scm.org/D2836
AFFECTED FILES
mercurial/debugcommands.py
mercurial/help/internals/wireprotocol.txt
indygreg planned changes to this revision.
indygreg added a comment.
I'm going to refactor tests for this to deal with an issue I had testing
things on my MBP.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2836
To: indygreg, #hg-reviewers
Cc: mercurial-devel
indygreg updated this revision to Diff 7014.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2836?vs=7010=7014
REVISION DETAIL
https://phab.mercurial-scm.org/D2836
AFFECTED FILES
mercurial/debugcommands.py
mercurial/help/internals/wireprotocol.txt
indygreg updated this revision to Diff 7010.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2836?vs=6999=7010
REVISION DETAIL
https://phab.mercurial-scm.org/D2836
AFFECTED FILES
mercurial/debugcommands.py
mercurial/help/internals/wireprotocol.txt
indygreg updated this revision to Diff 6999.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2836?vs=6982=6999
REVISION DETAIL
https://phab.mercurial-scm.org/D2836
AFFECTED FILES
mercurial/debugcommands.py
mercurial/help/internals/wireprotocol.txt
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Now that we have a scaffolding for serving version 2 of the HTTP
protocol, let's start implementing it.
A good place to start is URL routing and basic
