yuja added inline comments.
INLINE COMMENTS
> wireprotoserver.py:557
> elif action == 'noop':
> pass
> else:
Nit: `return False` instead of returning None?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2871
To: indygreg, #hg-reviewers,
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGbbea991635d0: wireproto: service multiple command requests
per HTTP request (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added inline comments.
INLINE COMMENTS
> wireprotoserver.py:508
> +
> +assert authedperm in (b'ro', b'rw')
> +wirecommand = wireproto.commands[command['command']]
worth not using assert here? I don't think this is attacker-controlled?
REPOSITORY
rHG Mercurial
indygreg updated this revision to Diff 7147.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2871?vs=7055=7147
REVISION DETAIL
https://phab.mercurial-scm.org/D2871
AFFECTED FILES
mercurial/help/internals/wireprotocol.txt
mercurial/wireprotoserver.py
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Now that our new frame-based protocol server can understand how
to ingest multiple, possibly interleaved, command requests, let's
hook it up to the HTTP
