D2924: rebase: rename conclude[memory]node() to commit[memory]node()

2018-03-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2924#47088, @phillco wrote: > What _is_ the difference between "conclude" and "commit"? I had assumed it was called "conclude" because it did more than commit (the stuff that's now in _concludecommit()). There's

D2924: rebase: rename conclude[memory]node() to commit[memory]node()

2018-03-21 Thread phillco (Phil Cohen)
phillco added a comment. What _is_ the difference between "conclude" and "commit"? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2924 To: martinvonz, phillco, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel ___

D2924: rebase: rename conclude[memory]node() to commit[memory]node()

2018-03-21 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa8d8cdafe29c: rebase: rename conclude[memory]node() to commit[memory]node() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2924: rebase: rename conclude[memory]node() to commit[memory]node()

2018-03-21 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Very nice cleanup! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2924 To: martinvonz, phillco, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel

D2924: rebase: rename conclude[memory]node() to commit[memory]node()

2018-03-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. martinvonz added a reviewer: phillco. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The functions do little more than commit at this point. REPOSITORY rHG Mercurial REVISION DETAIL