pulkit closed this revision.
pulkit added a comment.
This was committed as https://www.mercurial-scm.org/repo/hg/rev/a2a6755a3def.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2943
To: pulkit, #hg-reviewers, yuja, sangeet259
Cc: yuja, mercurial-devel
yuja accepted this revision.
yuja added a comment.
This revision is now accepted and ready to land.
Queued, thanks. Adjusted the commit message to close " (issue3885)".
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2943
To: sangeet259, #hg-reviewers, yuja
Cc:
sangeet259 updated this revision to Diff 7342.
sangeet259 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2943?vs=7321=7342
REVISION DETAIL
https://phab.mercurial-scm.org/D2943
AFFECTED FILES
mercurial/commands.py
sangeet259 added a comment.
@yuja rebase it on which revision?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2943
To: sangeet259, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
> This patch keeps the matches dictionary until
> the end of this window and clears it at once when this window ends.
This is really helpful while reading the patch. Perhaps
sangeet259 updated this revision to Diff 7321.
sangeet259 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2943?vs=7290=7321
REVISION DETAIL
https://phab.mercurial-scm.org/D2943
AFFECTED FILES
mercurial/commands.py
sangeet259 added a comment.
Currently, I am not sure what tests I should add, the tests in test-grep.t
are passing.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2943
To: sangeet259, #hg-reviewers
Cc: mercurial-devel
sangeet259 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
If grep is passed a revset in forwards order via -r , say -r 0:tip
Then the output is errorneous. This patch fixes that. The ouput was wrong
because
we
