This revision was automatically updated to reflect the committed changes.
Closed by commit rHG38a3767975a7: extensions: if on py3 and propname is a
bytestr, convert to sysstr (authored by durin42).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added a comment.
Take another look?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D296
To: durin42, #hg-reviewers
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
durin42 updated this revision to Diff 945.
durin42 marked 2 inline comments as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D296?vs=799=945
REVISION DETAIL
https://phab.mercurial-scm.org/D296
AFFECTED FILES
mercurial/extensions.py
CHANGE
yuja added inline comments.
INLINE COMMENTS
> yuja wrote in extensions.py:388
> `pycompat.sysstr()` ?
The "if" shouldn't be necessary. That's what `sysstr()` is for.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D296
To: durin42, #hg-reviewers
Cc: yuja,
durin42 added inline comments.
INLINE COMMENTS
> yuja wrote in extensions.py:401
> Perhaps this shouldn't be bytes. Needs `r''` and drop `_()`.
Done in a followup change.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D296
To: durin42, #hg-reviewers
Cc: yuja,
durin42 updated this revision to Diff 799.
durin42 marked 2 inline comments as done.
durin42 retitled this revision from "extensions: if on py3 and propname is a
bytestr, decode as ascii" to "extensions: if on py3 and propname is a bytestr,
convert to sysstr".
REPOSITORY
rHG Mercurial
