D2967: context: avoid using a context object as a changeid

2018-03-30 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdaef13da66fe: context: avoid using a context object as a changeid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2967: context: avoid using a context object as a changeid

2018-03-30 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Oh wow. Thanks for cleaning this up. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2967 To: martinvonz, #hg-reviewers, indygreg Cc: indygreg,

D2967: context: avoid using a context object as a changeid

2018-03-30 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I find it misleading to pass changeid=changectx. It currently works to do that because there's weird (IMO) handling of it in basectx.__new__. I'm planning on