This revision was automatically updated to reflect the committed changes.
Closed by commit rHGbb47dc2f71a0: context: move reuse of context object to
repo.__getitem__ (API) (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
That's 2 of us who think this is a good idea. I'm going to queue it.
If @smf knows of a reason why this is bad, we can always drop it or revert it.
REPOSITORY
rHG Mercurial
yuja added subscribers: smf, yuja.
yuja added a comment.
+1, but I don't remember why we made that hack.
@smf Any thoughts?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2969
To: martinvonz, #hg-reviewers
Cc: yuja, smf, mercurial-devel
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As an example of how weird the basectx.__new__ is: whenever you create
a workingctx, basectx.__new__ gets called first. Since our __new__ has
a "changeid"
