quark abandoned this revision.
quark added a comment.
> So there's no point to duplicate the HGDEMANDIMPORT check?
Hmm... I cannot remember why I did this at the first place. Just checking chg
alone should be enough.
REPOSITORY
rHG Mercurial
REVISION DETAIL
yuja added a comment.
> `sys.modules['hgdemandimport']` being set? Maybe I should remove it from
commit message.
So there's no point to duplicate the HGDEMANDIMPORT check?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D350
To: quark, #hg-reviewers
Cc:
quark added a comment.
`sys.modules['hgdemandimport']` being set? Maybe I should remove it from
commit message.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D350
To: quark, #hg-reviewers
Cc: yuja, mercurial-devel
yuja added a comment.
Seems fine, but what is the "side effects caused by importing demandimport" ?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D350
To: quark, #hg-reviewers
Cc: yuja, mercurial-devel
___
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This allows us to avoid side effects caused by importing demandimport if
demandimport is disabled. It also gives the hg script more control about
choosing whether
