This revision was automatically updated to reflect the committed changes.
Closed by commit rHGcd5f2e615262: extensions: new closehead module for closing
arbitrary heads (authored by joerg.sonnenberger, committed by ).
CHANGED PRIOR TO COMMIT
joerg.sonnenberger marked 2 inline comments as done.
joerg.sonnenberger added a comment.
Adjusted for most of the review comments. Added a test that books are left
alone, since they will not be active in the interesting cases. I'm not touching
any existing phases, so I'm not sure if I should
joerg.sonnenberger updated this revision to Diff 11254.
joerg.sonnenberger marked 5 inline comments as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3557?vs=11253=11254
REVISION DETAIL
https://phab.mercurial-scm.org/D3557
AFFECTED FILES
joerg.sonnenberger updated this revision to Diff 11253.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3557?vs=9400=11253
REVISION DETAIL
https://phab.mercurial-scm.org/D3557
AFFECTED FILES
hgext/closehead.py
tests/test-close-head.t
pulkit added a comment.
Sorry for getting late to review this. Found a minor nit and also looks like
you missed adding tests for bookmark movement and phase preservation.
INLINE COMMENTS
> closehead.py:55
> +
> +if not revs:
> +raise error.Abort(_('no revisions specified'))
joerg.sonnenberger updated this revision to Diff 9400.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3557?vs=9399=9400
REVISION DETAIL
https://phab.mercurial-scm.org/D3557
AFFECTED FILES
hgext/closehead.py
tests/test-close-head.t
joerg.sonnenberger updated this revision to Diff 9399.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3557?vs=8963=9399
REVISION DETAIL
https://phab.mercurial-scm.org/D3557
AFFECTED FILES
hgext/closehead.py
tests/test-close-head.t
pulkit added a comment.
Thanks for taking this out into a separate extension. Code looks mostly good
to me. It feels to me that we need some more tests:
- passing multiple revisions when some are head and some not
- closing a head which has secret phase
- checking for bookmark
joerg.sonnenberger updated this revision to Diff 8963.
joerg.sonnenberger edited the summary of this revision.
joerg.sonnenberger retitled this revision from "commit: add new close-branch
command" to "extensions: new closehead module for closing arbitrary heads".
REPOSITORY
rHG Mercurial
