This revision was automatically updated to reflect the committed changes.
Closed by commit rHG36ba5dba372d: advanceboundary: add dryrun parameter
(authored by khanchi97, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D3671?vs=8950=8957#toc
REPOSITORY
rHG Mercurial
pulkit added inline comments.
INLINE COMMENTS
> phases.py:505
> +changes = phcache.advanceboundary(repo, tr, targetphase, nodes,
> +dryrun=dryrun)
> +if not dryrun:
Fixed this indentation to align with opening brackets in flight.
khanchi97 updated this revision to Diff 8950.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3671?vs=8949=8950
REVISION DETAIL
https://phab.mercurial-scm.org/D3671
AFFECTED FILES
mercurial/phases.py
CHANGE DETAILS
diff --git a/mercurial/phases.py
khanchi97 updated this revision to Diff 8949.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3671?vs=8947=8949
REVISION DETAIL
https://phab.mercurial-scm.org/D3671
AFFECTED FILES
mercurial/phases.py
CHANGE DETAILS
diff --git a/mercurial/phases.py
pulkit added a comment.
Also, can you add about why we are adding a dryrun parameter to functions
here and what will be the behavior in the commit message too?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3671
To: khanchi97, #hg-reviewers, pulkit
Cc: pulkit,
pulkit added a comment.
Nice work! Returning a set of changesets whose phase is changed or can be
changed is a better API than returning a rejected list and a list of sets.
INLINE COMMENTS
> phases.py:358
>
> Nodes with a phase lower than 'targetphase' are not affected.
>
khanchi97 updated this revision to Diff 8947.
khanchi97 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3671?vs=8940=8947
REVISION DETAIL
https://phab.mercurial-scm.org/D3671
AFFECTED FILES
mercurial/phases.py
khanchi97 updated this revision to Diff 8940.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3671?vs=8928=8940
REVISION DETAIL
https://phab.mercurial-scm.org/D3671
AFFECTED FILES
mercurial/phases.py
CHANGE DETAILS
diff --git a/mercurial/phases.py
khanchi97 added inline comments.
INLINE COMMENTS
> khanchi97 wrote in phases.py:371
> I thought we would calculate `rejected` only when we are in dryrun mode.
okay its fine. I will remove this unnecessary condition. Because I think
`rejected` value can also be used in `phase` method of
khanchi97 added inline comments.
INLINE COMMENTS
> pulkit wrote in phases.py:369
> why are we maintaining this rejected list?
rejected list will contain those csets which will be rejected during advancing
boundary and then return this list so that we can report for rejected csets
during
pulkit requested changes to this revision.
pulkit added a comment.
This revision now requires changes to proceed.
Thanks for breaking this up. I have some put comments which are mostly
doubts, can you explain by replying to them why you did so?
INLINE COMMENTS
> phases.py:369
>
> +
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Added logic to find those csets whose phase will be changed (when
running without --dryrun) while advancing boundary. And make it return
rejected and changed
12 matches
Mail list logo
