pulkit added a comment.
@rishabhmadan96 Sorry for jumping late, can you followup with a patch adding
some docs for the flag. Also document the behavior of `hg releasenotes -c` and
it will be great if you can add a test for that too.
REPOSITORY
rHG Mercurial
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6a49c74b1e8f: releasenotes: add check flag for use of
admonitions and its validity (authored by rishabhmadan96).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D368?vs=973=1200#toc
REPOSITORY
krbullock accepted this revision.
krbullock added a comment.
Looks good, queued!
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D368
To: rishabhmadan96, #hg-reviewers, durin42, krbullock
Cc: krbullock, quark, durin42, mercurial-devel
quark added a comment.
In https://phab.mercurial-scm.org/D368#6402, @rishabhmadan96 wrote:
> Sorry I just edited the revision string. Will that work? Or should I update
it again with "Differential Revision: https://phab.mercurial-scm.org/D368; at
the end.
No worries. The title
rishabhmadan96 added a comment.
Sorry I just edited the revision string. Will that work? Or should I update
it again with "Differential Revision: https://phab.mercurial-scm.org/D368; at
the end.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D368
To:
durin42 requested changes to this revision.
durin42 added a comment.
This revision now requires changes to proceed.
A style nit, generally +1 and if you get the style nits handled we should be
good to go.
INLINE COMMENTS
> releasenotes.py:266
> +else:
> +
rishabhmadan96 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
While using releasenotes extension, we will be using admonitions in commit
messages.
The check (-c) flag will look for an admonition within the message.
