Sounds good
On Fri, Aug 24, 2018, 07:07 pulkit (Pulkit Goyal) <
phabrica...@mercurial-scm.org> wrote:
> pulkit added inline comments.
>
> INLINE COMMENTS
>
> > foozy wrote in narrowcommands.py:303
> > Just curious, is it intentional that the name of this option is
> different from
pulkit added inline comments.
INLINE COMMENTS
> foozy wrote in narrowcommands.py:303
> Just curious, is it intentional that the name of this option is different
> from `--import-rules` of debugsparse ?
I didn't know about that. That likes a good name, @martinvonz what do you think?
REPOSITORY
foozy added inline comments.
INLINE COMMENTS
> martinvonz wrote in narrowcommands.py:303
> It looks like it just adds includes and excludes (but yes, adding excludes
> means removing files), so I think the name makes sense
Just curious, is it intentional that the name of this option is
martinvonz added inline comments.
INLINE COMMENTS
> pulkit wrote in narrowcommands.py:303
> I thought about `--addfromfile` and dropped it because you can both add and
> remove includes and excludes using this option. Add in other flags means
> adding either include or exclude specs.
>
> I am
pulkit planned changes to this revision.
pulkit added inline comments.
INLINE COMMENTS
> martinvonz wrote in narrowcommands.py:303
> nit: `--extend` may be too generic. How about `--addfromfile`? Can be done in
> a follow-up if you agree.
I thought about `--addfromfile` and dropped it because
martinvonz added inline comments.
INLINE COMMENTS
> narrowcommands.py:303
> ('', 'addexclude', [], _('new paths to exclude')),
> + ('', 'extend', '', _('file to read to extend the narrowspec')),
> ('', 'removeexclude', [], _('old paths to no longer exclude')),
nit: `--extend`
durin42 added a comment.
needs rebased, but looks fine to me
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4125
To: pulkit, durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel
___
Mercurial-devel mailing list
pulkit added a comment.
ping for review.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4125
To: pulkit, durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel
___
Mercurial-devel mailing list
pulkit added a comment.
In https://phab.mercurial-scm.org/D4125#64732, @durin42 wrote:
> Seems fine to me, though thinking we should probably spend some time to
make sure the sparse and narrow patterns are cross-compatible like this change
seems to hope for.
I already did that.
durin42 accepted this revision as: durin42.
durin42 added a subscriber: martinvonz.
durin42 added a comment.
Seems fine to me, though thinking we should probably spend some time to make
sure the sparse and narrow patterns are cross-compatible like this change seems
to hope for.
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch adds a `--extend` flag to tracked command provided by narrow
extension. Using the --extend flag, you can pass a
11 matches
Mail list logo
