durin42 added a comment.
> This is taking the start time before the `readline()`. So, the time will be
misreported if it takes a while for an event to arrive.
Gloriously, this doesn’t actually matter! As long as we have a fixed
reference time for the entire event stream it isn’t a big
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG9a81f126f9fa: contrib: new script to read events from a
named pipe and emit catapult traces (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg added a comment.
In https://phab.mercurial-scm.org/D4342#66811, @durin42 wrote:
> Oh, and I'm really not in love with the `catapipe.py` name - got any
suggestions for something better?
Nothing definitive. But since this is related to tracing, maybe have
`tracing` in the
durin42 added a comment.
In https://phab.mercurial-scm.org/D4342#66810, @durin42 wrote:
> In https://phab.mercurial-scm.org/D4342#66808, @indygreg wrote:
>
> > Overall this series seems pretty reasonably and exciting! You say it is
RFC-ish. But aside from the possibly-too-early
durin42 added a comment.
In https://phab.mercurial-scm.org/D4342#66808, @indygreg wrote:
> Overall this series seems pretty reasonably and exciting! You say it is
RFC-ish. But aside from the possibly-too-early import in `hg`, I'm tempted to
queue this.
That's honestly fine with
indygreg added a comment.
Overall this series seems pretty reasonably and exciting! You say it is
RFC-ish. But aside from the possibly-too-early import in `hg`, I'm tempted to
queue this.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4342
To: durin42,
durin42 added a comment.
This series is RFC-ish: I'd very much like to land it (and find additional
things we could have emit events!), but I also am not really in love with any
of the names involved.
It looks like it'll be useful to debug some slowness problems at Google, at
the very
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I'm starting to get more serious about getting some insight into where
we're spending our time, both in hg itself but also in the test
suite. As a first pass,
