Re: D464: Use an unambigious path suffix for the commit editor file.

2017-08-22 Thread Sean Farley
Jun Wu writes: > I think this patch is about changing the suffix. I guess some less powerful > editors may only support matching file types by suffixes. Yeah, it seems that way. > Please correct me if I'm wrong, but I failed to see how the > "experimental.editortmpinhg" setting could be used a

Re: D464: Use an unambigious path suffix for the commit editor file.

2017-08-22 Thread Jun Wu
I think this patch is about changing the suffix. I guess some less powerful editors may only support matching file types by suffixes. Please correct me if I'm wrong, but I failed to see how the "experimental.editortmpinhg" setting could be used as-is to change the suffix. Therefore I think the pat

Re: D464: Use an unambigious path suffix for the commit editor file.

2017-08-21 Thread Sean Farley
mbolin (Michael Bolin) writes: > mbolin created this revision. > Herald added a subscriber: mercurial-devel. > Herald added a reviewer: hg-reviewers. > > REVISION SUMMARY > Changes the path for a commit editor file from `/tmp/hg-editor-XX.txt` > to > `/tmp/hg-editor-XX.hgcommit.txt`

D464: Use an unambigious path suffix for the commit editor file.

2017-08-21 Thread mbolin (Michael Bolin)
mbolin created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Changes the path for a commit editor file from `/tmp/hg-editor-XX.txt` to `/tmp/hg-editor-XX.hgcommit.txt`. Some editors (such as Atom) make it possibl