mharbison72 added a comment.
In https://phab.mercurial-scm.org/D5025#76443, @mharbison72 wrote:
> In https://phab.mercurial-scm.org/D5025#75556, @yuja wrote:
>
> > > def perfstartup(ui, repo, **opts):
> > > opts = _byteskwargs(opts)
> > > timer, fm = gettimer(ui,
mharbison72 added a comment.
In https://phab.mercurial-scm.org/D5025#75556, @yuja wrote:
> > def perfstartup(ui, repo, **opts):
> > opts = _byteskwargs(opts)
> > timer, fm = gettimer(ui, opts)
> >
> > - cmd = sys.argv[0] +cmd = fsencode(sys.argv[0])
>
>
yuja added a comment.
> >> - cmd = sys.argv[0] +cmd = fsencode(sys.argv[0])
> >
> > Applying fsencode() on sys.argv is probably wrong on Windows, but it's
perf.py,
> > I don't care.
>
> What's the right way to do it on windows?
I think `encoding.strtolocal()`
> >> - cmd = sys.argv[0] +cmd = fsencode(sys.argv[0])
> >
> > Applying fsencode() on sys.argv is probably wrong on Windows, but it's
> perf.py,
> > I don't care.
>
> What's the right way to do it on windows?
I think `encoding.strtolocal()` is close, but I have no idea what's
pulkit added a comment.
>> def perfstartup(ui, repo, **opts):
>> opts = _byteskwargs(opts)
>> timer, fm = gettimer(ui, opts)
>>
>> - cmd = sys.argv[0] +cmd = fsencode(sys.argv[0])
>
> Applying fsencode() on sys.argv is probably wrong on Windows, but it's
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb456b2e0ad9f: py3: make test-contrib-perf.t work on python
3 (authored by pulkit, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D5025?vs=11959=11980#toc
REPOSITORY
rHG
yuja added a comment.
> - a/contrib/perf.py +++ b/contrib/perf.py @@ -75,14 +75,16 @@ _byteskwargs
= pycompat.byteskwargs # since 4.1 (or
https://phab.mercurial-scm.org/rHGfbc3f73dc802774fbda1fa5da02af1157b637038)
_sysstr = pycompat.sysstr # since 4.0 (or
> --- a/contrib/perf.py
> +++ b/contrib/perf.py
> @@ -75,14 +75,16 @@
> _byteskwargs = pycompat.byteskwargs # since 4.1 (or fbc3f73dc802)
> _sysstr = pycompat.sysstr # since 4.0 (or 2219f4f82ede)
> _xrange = pycompat.xrange # since 4.8 (or 7eba8f83129b)
> +
pulkit created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5025
AFFECTED FILES
contrib/perf.py
contrib/python3-whitelist
CHANGE DETAILS
diff --git
