This revision now requires changes to proceed.
baymax added a comment.
baymax requested changes to this revision.
There seems to have been no activities on this Diff for the past 3 Months.
By policy, we are automatically moving it out of the `need-review` state.
Please, move it back
durin42 added a comment.
Per mailing list thread, I've sent out https://phab.mercurial-scm.org/D5539
to show what yapf would want to do.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5064
To: mjpieters, indygreg, durin42, #hg-reviewers
Cc: mharbison72, av6,
durin42 added a comment.
In https://phab.mercurial-scm.org/D5064#78994, @mharbison72 wrote:
> In https://phab.mercurial-scm.org/D5064#78990, @durin42 wrote:
>
> > Does anyone strongly object, or do we want to embrace black and the
formatting changes it implies?
>
>
> Is there a
mharbison72 added a comment.
In https://phab.mercurial-scm.org/D5064#78990, @durin42 wrote:
> Does anyone strongly object, or do we want to embrace black and the
formatting changes it implies?
Is there a fix extension configuration (and I guess precommit hook- I've
never used
durin42 added a comment.
In https://phab.mercurial-scm.org/D5064#78780, @mjpieters wrote:
> In https://phab.mercurial-scm.org/D5064#78545, @av6 wrote:
>
> > I look at the changes and see nitpicks at best. On the one hand, black
proved better than any linter that we can already write
mjpieters added a comment.
In https://phab.mercurial-scm.org/D5064#78545, @av6 wrote:
> I look at the changes and see nitpicks at best. On the one hand, black
proved better than any linter that we can already write consistent code. On the
other, if black were a linter... I'd switch to
av6 added a comment.
I look at the changes and see nitpicks at best. On the one hand, black proved
better than any linter that we can already write consistent code. On the other,
if black were a linter... I'd switch to flake8, which at least is configurable
indygreg added a comment.
Where do we stand on the intent to mass reformat the code base?
I'm not super thrilled at some of black's decisions (like using double quotes
for all strings and merging imports into the same line which leads to excessive
code churn later). But the exact style
mjpieters updated this revision to Diff 12135.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5064?vs=12059=12135
REVISION DETAIL
https://phab.mercurial-scm.org/D5064
AFFECTED FILES
contrib/import-checker.py
mercurial/cacheutil.py
indygreg added inline comments.
INLINE COMMENTS
> check-commit:43
> -(r"\n\+\n( |\+)\n", "adds double empty line"),
> -(r"\n \n\+\n", "adds double empty line"),
> # Forbid "_" in function name.
I think we'll want to send this chunk as a separate commit, as it is a policy
change.
mjpieters updated this revision to Diff 12059.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5064?vs=12047=12059
REVISION DETAIL
https://phab.mercurial-scm.org/D5064
AFFECTED FILES
contrib/check-commit
contrib/import-checker.py
mjpieters updated this revision to Diff 12047.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5064?vs=12030=12047
REVISION DETAIL
https://phab.mercurial-scm.org/D5064
AFFECTED FILES
mercurial/cacheutil.py
mercurial/diffhelper.py
mjpieters added a comment.
The `import` parentheses collapsing is described here:
https://github.com/ambv/black#parentheses. The behavior is not configurable.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5064
To: mjpieters, indygreg, durin42, #hg-reviewers
mjpieters created this revision.
mjpieters added reviewers: indygreg, durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This applied black to the 20 smallest files in mercurial/:
ls -S1 mercurial/*.py | tail -n20 | xargs black
14 matches
Mail list logo
