D5075: tests: accept slightly different zip file in Python 3

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg added a comment. https://github.com/python/cpython/commit/44989bc2696320cf55ae6f329aaf58edd49d792a is likely the commit introducing the divergence. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5075 To: durin42, pulkit, #hg-reviewers Cc: indygreg, yu

D5075: tests: accept slightly different zip file in Python 3

2018-10-13 Thread indygreg (Gregory Szorc)
indygreg added a comment. Behavior changed between Python 3.6 and Python 3.7. We should add `pyXX` hghave capabilities to differentiate on Python versions. Or we could annotate all possible lines with `(?)` (optional output). The hghave approach is better. REPOSITORY rHG Mercurial RE

D5075: tests: accept slightly different zip file in Python 3

2018-10-13 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D5075#76125, @pulkit wrote: > In https://phab.mercurial-scm.org/D5075#76117, @yuja wrote: > > > > - body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e6192068650 + body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e61920686

D5075: tests: accept slightly different zip file in Python 3

2018-10-13 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D5075#76117, @yuja wrote: > > - body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e6192068650 + body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e6192068650 (no-py3k !) + body: size=1461, sha1=be6d3983aa13dfe930361b2569291cde

D5075: tests: accept slightly different zip file in Python 3

2018-10-13 Thread yuja (Yuya Nishihara)
yuja added a comment. > - body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e6192068650 + body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e6192068650 (no-py3k !) + body: size=1461, sha1=be6d3983aa13dfe930361b2569291cdedd02b537 (py3k !) For some reason, my Python 3 says `size=1489

Re: D5075: tests: accept slightly different zip file in Python 3

2018-10-13 Thread Yuya Nishihara
> - body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e6192068650 > + body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e6192068650 (no-py3k !) > + body: size=1461, sha1=be6d3983aa13dfe930361b2569291cdedd02b537 (py3k !) For some reason, my Python 3 says `size=1489, sha1=1897e496871aa89ad685a9

D5075: tests: accept slightly different zip file in Python 3

2018-10-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc9e8c93e241c: tests: accept slightly different zip file in Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5075?vs=1

D5075: tests: accept slightly different zip file in Python 3

2018-10-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I added some `unzip -t` here and I *think* the only change is from Python 3 having more data in the zip file headers or