We've had some discussion about this on irc. The evolve behavior of preserving
empty commits is important in one circumstance: when the commit will briefly be
empty, but should retain its identity for the purposes of evolution.
Personally, I've never used uncommit and ended up with an empty comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd01819c8f3c4: uncommit: move fb-extension to core which
uncommits a changeset (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D
pulkit updated this revision to Diff 1823.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D529?vs=1729&id=1823
REVISION DETAIL
https://phab.mercurial-scm.org/D529
AFFECTED FILES
hgext/uncommit.py
tests/test-uncommit.t
CHANGE DETAILS
diff --git a/te
quark accepted this revision.
quark added a comment.
Generally look good to me. I think core hg does not have very convenient
commit editing APIs yet (memctx feels too low-level). I'm counting on
in-memory-memory work to provide convenient APIs eventually. So I'd hold on
refactoring until we
pulkit marked 15 inline comments as done.
pulkit added inline comments.
INLINE COMMENTS
> yuja wrote in uncommit.py:173
> I'm not sure if this `retractboundary()` is valid. cmdutil.amend()
> appears to use phases.new-commit config instead.
The phases.new-commit config update the phase to old.pha
pulkit updated this revision to Diff 1729.
pulkit edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D529?vs=1712&id=1729
REVISION DETAIL
https://phab.mercurial-scm.org/D529
AFFECTED FILES
hgext/uncommit.py
tests/test
durham accepted this revision.
durham added a comment.
Looks good, except for my ui.allowemptycommit comment.
INLINE COMMENTS
> uncommit.py:59
> +files = (initialfiles - exclude)
> +allowempty = allowempty or repo.ui.configbool('ui', 'allowemptycommit')
> +if not files and not all
pulkit updated this revision to Diff 1712.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D529?vs=1330&id=1712
REVISION DETAIL
https://phab.mercurial-scm.org/D529
AFFECTED FILES
hgext/uncommit.py
tests/test-uncommit.t
CHANGE DETAILS
diff --git a/te
pulkit added a comment.
In https://phab.mercurial-scm.org/D529#10887, @quark wrote:
> Please address other reviewers' comments.
Yeah will do that soon, was busy for past few days.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D529
To: pulkit, #hg-re
quark requested changes to this revision.
quark added a comment.
This revision now requires changes to proceed.
Please address other reviewers' comments.
INLINE COMMENTS
> uncommit.py:12
> +
> +"""uncommit some or all of a local changeset
> +
I'd add "(EXPERIMENTAL)". The command does not wr
martinvonz added inline comments.
INLINE COMMENTS
> uncommit.py:16
> +files to their uncommitted state. This means that files modified or
> +deleted in the changeset will be left unchanged, and so will remain modified
> in
> +the working directory.
How about added files? Also, I think we use "r
yuja added a comment.
Overall, the patch looks good, but I don't have expertise in this area.
> The uncommit extension in fb-hgext does not creates an empty commit like
the one
> in evolve extension unless user has specified ui.alllowemptycommit to True.
Maybe we'll need a command
pulkit added a comment.
This has been in from a week, any updates on this?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D529
To: pulkit, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-dev
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
uncommit extension in fb-hgext adds a uncommit command which by default
uncommits a changeset and move all the changes to the working directory. If
file names are
14 matches
Mail list logo
