D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off"

2018-12-15 Thread yuja (Yuya Nishihara)
yuja added a comment. I feel `--no-` and `--=off|false` are more natural, and `(default: %s)` is the latter form. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5444 To: av6, durin42, #hg-reviewers Cc: yuja, martinvonz, pulkit, mercurial-devel

Re: D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off"

2018-12-15 Thread Yuya Nishihara
I feel `--no-` and `--=off|false` are more natural, and `(default: %s)` is the latter form. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off"

2018-12-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. Arguments against yes/no: 1. "default: yes/no" can easily be read as "is this a default", which is not quite the same, although it would have the same effect. 2. On/off fits well in sentences like "is --hidden on by default". I see your arguments too

D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off"

2018-12-15 Thread av6 (Anton Shestakov)
av6 added a comment. The point of https://phab.mercurial-scm.org/D5430 was to make hg help output more human friendly by replacing `True` and `False` with something less Python-related. In other words, more human-friendly. "Yes" and "no" are way more human-friendly: - they are one of

D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off"

2018-12-15 Thread pulkit (Pulkit Goyal)
pulkit added a comment. TBH, I think 'on' and 'off' are more appropriate than 'yes' and 'no'. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5444 To: av6, durin42, #hg-reviewers Cc: pulkit, mercurial-devel ___

D5444: help: use "yes" and "no" for boolean defaults instead of "on" and "off"

2018-12-15 Thread av6 (Anton Shestakov)
av6 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5444 AFFECTED FILES mercurial/help.py tests/test-extension.t