indygreg abandoned this revision.
indygreg added a comment.
This got rolled into https://phab.mercurial-scm.org/D558. `hg phabsend`
didn't appear smart enough to discard it from Phabricator when I pushed the new
stack.
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg added inline comments.
INLINE COMMENTS
> quark wrote in show.py:440
> I'd call low level function without template and maintain a current minlen to
> reduce calculation.
The current minlen code is semi-tightly integrated with the templating layer.
I agree with you that a generic
yuja added inline comments.
INLINE COMMENTS
> quark wrote in show.py:428
> How about minlen=4? It could be useful in small repos.
minlen=4 seems better than 3. `_partialmatch()` falls through to
slow path if `nodelen < 4`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
quark added inline comments.
INLINE COMMENTS
> show.py:428
>
> +def longestshortest(repo, revs, minlen=5):
> +"""Return the length of the longest shortest node to identify revisions.
How about minlen=4? It could be useful in small repos.
> show.py:440
> +"""
> +tmpl =
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
`hg show` makes heavy use of shortest() to limit the length of the node
hash.
For the "stack" and "work" views, you are often looking at multiple
lines of
