mharbison72 added a comment.
Maybe a py3 thing?
$ py -3 run-tests.py --local test-http.t
running 1 tests using 1 parallel processes
--- c:/Users/Matt/hg/tests/test-http.t
+++ c:/Users/Matt/hg/tests/test-http.t.err
@@ -1,58 +1,262 @@
#require serve
$
martinvonz marked an inline comment as done.
martinvonz added inline comments.
INLINE COMMENTS
> mharbison72 wrote in scmutil.py:741
> 2 too many quotes here are causing stacktraces.
Fixed in the hg-committed repo.
What kind of stacktraces? I'm curious why I didn't see them.
REPOSITORY
rHG
mharbison72 added inline comments.
INLINE COMMENTS
> scmutil.py:741
> +of what ui.relative-paths is set to.
> +"
> +if forcerelativevalue is not None:
2 too many quotes here are causing stacktraces.
REPOSITORY
rHG Mercurial
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc56d80871eac: config: introduce a new value for
ui.relative-paths getting old behavior (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
martinvonz updated this revision to Diff 13811.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5800?vs=13732=13811
REVISION DETAIL
https://phab.mercurial-scm.org/D5800
AFFECTED FILES
mercurial/commands.py
mercurial/configitems.py
martinvonz added a comment.
In https://phab.mercurial-scm.org/D5800#85624, @yuja wrote:
> > So do we prefer `legacyrelativevalue` then? Or `legacywasrelative`? Or
`legacyrelative`? (I think the last one is least clear.)
>
> `legacyrelativevalue` sounds good to me.
Okay, I
yuja added a comment.
> So do we prefer `legacyrelativevalue` then? Or `legacywasrelative`? Or
`legacyrelative`? (I think the last one is least clear.)
`legacyrelativevalue` sounds good to me.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5800
To:
> So do we prefer `legacyrelativevalue` then? Or `legacywasrelative`? Or
> `legacyrelative`? (I think the last one is least clear.)
`legacyrelativevalue` sounds good to me.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
martinvonz added a comment.
In https://phab.mercurial-scm.org/D5800#85228, @yuja wrote:
> > > What I thought confusing is `scmutil.getuipathfn(ctx.repo(),
legacyvalue=True)`
> > > in https://phab.mercurial-scm.org/D5801. "What does the `True` mean?
relative, absolute, or a
yuja added a comment.
> > What I thought confusing is `scmutil.getuipathfn(ctx.repo(),
legacyvalue=True)`
> > in https://phab.mercurial-scm.org/D5801. "What does the `True` mean?
relative, absolute, or a complete
> > different stuff?"
>
> Same reason it's confusing, I
> > What I thought confusing is `scmutil.getuipathfn(ctx.repo(),
> legacyvalue=True)`
> > in https://phab.mercurial-scm.org/D5801. "What does the `True` mean?
> relative, absolute, or a complete
> > different stuff?"
>
> Same reason it's confusing, I believe: it's unclear if
martinvonz added a comment.
In https://phab.mercurial-scm.org/D5800#85220, @yuja wrote:
> > > Looks good, but I find it isn't easy to parse the meaning of
> > > `getuipathfn(repo, forcevalue=True)`. Perhaps it can be spelled as
> > > `forcerelative=True`.
> >
> > The
yuja added a comment.
> > Looks good, but I find it isn't easy to parse the meaning of
> > `getuipathfn(repo, forcevalue=True)`. Perhaps it can be spelled as
> > `forcerelative=True`.
>
> The problem is that this an override value for a boolean value, so it's
easy to
> > Looks good, but I find it isn't easy to parse the meaning of
> > `getuipathfn(repo, forcevalue=True)`. Perhaps it can be spelled as
> > `forcerelative=True`.
>
> The problem is that this an override value for a boolean value, so it's
> easy to mistake `forcerelative=False` to
martinvonz updated this revision to Diff 13732.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5800?vs=13698=13732
REVISION DETAIL
https://phab.mercurial-scm.org/D5800
AFFECTED FILES
mercurial/commands.py
mercurial/configitems.py
martinvonz added a comment.
In https://phab.mercurial-scm.org/D5800#85128, @yuja wrote:
> Looks good, but I find it isn't easy to parse the meaning of
> `getuipathfn(repo, forcevalue=True)`. Perhaps it can be spelled as
> `forcerelative=True`.
The problem is that this an
yuja added a comment.
Looks good, but I find it isn't easy to parse the meaning of
`getuipathfn(repo, forcevalue=True)`. Perhaps it can be spelled as
`forcerelative=True`.
> +def getuipathfn(repo, legacyvalue=False, forcevalue=None):
> +if forcevalue is not None:
> +
Looks good, but I find it isn't easy to parse the meaning of
`getuipathfn(repo, forcevalue=True)`. Perhaps it can be spelled as
`forcerelative=True`.
> +def getuipathfn(repo, legacyvalue=False, forcevalue=None):
> +if forcevalue is not None:
> +relative = forcevalue
> +else:
> +
18 matches
Mail list logo
