D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

Herald added a subscriber: mercurial-patches. This revision now requires changes to proceed. baymax added a comment. baymax requested changes to this revision. There seems to have been no activities on this Diff for the past 3 Months. By policy, we are automatically moving it out of the

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

marmoute added a comment. Gentle ping on this. This has been around for a long time, what's the status of it? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6026/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6026 To: akshjain.jain74,

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

akshjain.jain74 added a comment. In https://phab.mercurial-scm.org/D6026#88552, @pulkit wrote: > I am not sure the new message is much helpful. As JordiGH and others pointed out on IRC, it will definitely be helpful if we can show which operation has the lock right now. > >

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

akshjain.jain74 added a comment. okay @pulkit let me work upon your suggestion and INLINE COMMENTS > pulkit wrote in test-lock-badness.t:18 > still here are unrealted changes. I accept these changes while running test, if i am not changing this then it will cause test failing REPOSITORY

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

pulkit added a comment. I am not sure the new message is much helpful. As JordiGH and others pointed out on IRC, it will definitely be helpful if we can show which operation has the lock right now. Something like: `waiting for lock on working directory of b held by process '*'

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

akshjain.jain74 updated this revision to Diff 14291. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6026?vs=14279=14291 REVISION DETAIL https://phab.mercurial-scm.org/D6026 AFFECTED FILES hgext/journal.py mercurial/lock.py

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

akshjain.jain74 marked an inline comment as done. akshjain.jain74 added a comment. @pulkit done changes as per your suggestion in lock file too but what did you meant by storelock? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6026 To: akshjain.jain74,

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

akshjain.jain74 updated this revision to Diff 14279. akshjain.jain74 marked 2 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6026?vs=14277=14279 REVISION DETAIL https://phab.mercurial-scm.org/D6026 AFFECTED FILES

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

pulkit added inline comments. INLINE COMMENTS > journal.py:310 > self.ui.warn( > -_("waiting for lock on %s held by %r\n") % (desc, > inst.locker)) > +_("waiting for lock on %s held by %r\n" "on host %r\n" > +"""Another Mercurial

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

akshjain.jain74 updated this revision to Diff 14277. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6026?vs=14274=14277 REVISION DETAIL https://phab.mercurial-scm.org/D6026 AFFECTED FILES hgext/journal.py tests/test-lock-badness.t CHANGE DETAILS

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

akshjain.jain74 updated this revision to Diff 14274. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6026?vs=14273=14274 REVISION DETAIL https://phab.mercurial-scm.org/D6026 AFFECTED FILES hgext/journal.py tests/test-lock-badness.t CHANGE DETAILS

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

akshjain.jain74 updated this revision to Diff 14273. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6026?vs=14272=14273 REVISION DETAIL https://phab.mercurial-scm.org/D6026 AFFECTED FILES hgext/journal.py tests/test-lock-badness.t CHANGE DETAILS

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

akshjain.jain74 updated this revision to Diff 14272. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6026?vs=14271=14272 REVISION DETAIL https://phab.mercurial-scm.org/D6026 AFFECTED FILES hgext/journal.py tests/test-lock-badness.t CHANGE DETAILS

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

akshjain.jain74 updated this revision to Diff 14271. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6026?vs=14244=14271 REVISION DETAIL https://phab.mercurial-scm.org/D6026 AFFECTED FILES hgext/journal.py tests/test-lock-badness.t CHANGE DETAILS

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

akshjain.jain74 added a comment. Ya I am sending that just trying to find out the file REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6026 To: akshjain.jain74, #hg-reviewers Cc: pulkit, mercurial-devel ___

D6026: lock: Improve the waiting for lock message which will help newcomers(issue6081)

pulkit added a comment. This patch does not changes any code. It only changes some test output. You need to change the error message in the code. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6026 To: akshjain.jain74, #hg-reviewers Cc: pulkit, mercurial-devel