This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5997eabc7b85: push: added clear warning message when
pushing closed branches(issue6080) (authored by taapas1128, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit added a comment.
Queuing this, many thanks!
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6038
To: taapas1128, #hg-reviewers, pulkit
Cc: pulkit, mharbison72, mercurial-devel
___
Mercurial-devel mailing list
pulkit added a comment.
@taapas1128 when you get time, can you see whether reading the branchmap can
slow down things or not. It other words, can you test some performance numbers
with it?
A good way to do that is to enable `contrib/perf.py` as perf extension and
use `hg perfdiscovery`
taapas1128 added a comment.
@pulkit done.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6038
To: taapas1128, #hg-reviewers
Cc: pulkit, mharbison72, mercurial-devel
___
Mercurial-devel mailing list
taapas1128 updated this revision to Diff 14534.
taapas1128 marked 4 inline comments as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6038?vs=14507=14534
REVISION DETAIL
https://phab.mercurial-scm.org/D6038
AFFECTED FILES
mercurial/discovery.py
pulkit added a comment.
Nice work, I have left some inline comments. Can you also add a test where we
pushing multiple branches and not every branch is a closed branch?
INLINE COMMENTS
> discovery.py:348
> +# Makes a list of closed branches
> +closedbranches = []
> +for tag,
taapas1128 updated this revision to Diff 14507.
taapas1128 retitled this revision from "push: added clear warning message when
pushing a closed branch(issue6080)" to "push: added clear warning message when
pushing closed branches(issue6080)".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST
