D6042: py3: convert filtername to str if it's None

This revision was automatically updated to reflect the committed changes. Closed by commit rHG38de3300414f: py3: convert filtername to str if its None (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6042?vs=14321=14341

D6042: py3: convert filtername to str if it's None

pulkit updated this revision to Diff 14321. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6042?vs=14320=14321 REVISION DETAIL https://phab.mercurial-scm.org/D6042 AFFECTED FILES mercurial/branchmap.py CHANGE DETAILS diff --git

D6042: py3: convert filtername to str if it's None

pulkit updated this revision to Diff 14320. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6042?vs=14285=14320 REVISION DETAIL https://phab.mercurial-scm.org/D6042 AFFECTED FILES mercurial/branchmap.py

D6042: py3: convert filtername to str if it's None

yuja added a comment. > +filtername = repo.filtername > +if filtername is None: > +filtername = 'None' > > repo.ui.log('branchcache', 'updated %s branch cache in %.4f seconds\n', > > - repo.filtername, duration) +filtername,

Re: D6042: py3: convert filtername to str if it's None

> +filtername = repo.filtername > +if filtername is None: > +filtername = 'None' > repo.ui.log('branchcache', 'updated %s branch cache in %.4f > seconds\n', > -repo.filtername, duration) > +filtername, duration)

D6042: py3: convert filtername to str if it's None

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I have not called pycompat.bytestr() and rather converted the value there because I am starting to get concerned about the function call overhead of all this