This revision now requires changes to proceed.
baymax added a comment.
baymax requested changes to this revision.
There seems to have been no activities on this Diff for the past 3 Months.
By policy, we are automatically moving it out of the `need-review` state.
Please, move it back
durin42 added a comment.
This patch breaks `test-split.t` - could you take a look?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6056/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6056
To: navaneeth.suresh, #hg-reviewers
Cc: durin42,
navaneeth.suresh added a comment.
Gentle ping for review.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6056
To: navaneeth.suresh, #hg-reviewers
Cc: pulkit, mercurial-devel
___
Mercurial-devel mailing list
navaneeth.suresh added inline comments.
INLINE COMMENTS
> pulkit wrote in test-mq-qrefresh.t:570
> I don't see the output which asks for `record this change to foo.h` here in
> the test.
IIUC, the current scenario is running into `abort: cannot create foo.h:
destination already exists` if an
pulkit added inline comments.
INLINE COMMENTS
> navaneeth.suresh wrote in test-mq-qrefresh.t:570
> i think that's usual here as the file `foo.h` is empty. i have the following
> case running successfully with this patch:
>
> $ echo foo > foo.h
> $ hg add foo.h
> $ hg qrefresh -i --config
navaneeth.suresh added inline comments.
INLINE COMMENTS
> pulkit wrote in test-mq-qrefresh.t:570
> does this prompt ended here? it didn't show changes in 'foo.h'?
i think that's usual here as the file `foo.h` is empty. i have the following
case running successfully with this patch:
$ echo
pulkit added inline comments.
INLINE COMMENTS
> test-mq-qrefresh.t:570
> + new file mode 100644
> + examine changes to 'foo.h'? [Ynesfdaq?] y
> +
does this prompt ended here? it didn't show changes in 'foo.h'?
REPOSITORY
rHG Mercurial
REVISION DETAIL
navaneeth.suresh updated this revision to Diff 14492.
navaneeth.suresh retitled this revision from "patch: stop aborting when
ADD/RENAME/COPY files on --interactive (issue5727)" to "patch: stop aborting
when add/rename/copy files on --interactive (issue5727)".
REPOSITORY
rHG Mercurial
navaneeth.suresh created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
issue5727 was reported specifically for mq on using qrefresh. On
investigating further,
I realized that it was a check in `patch.py` that resulting in
