D608: wireproto: do not abort after successful lookup

2017-09-03 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6c6169f71b8d: wireproto: do not abort after successful lookup (authored by spectral). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D608?vs=1560=1588 REVISION

D608: wireproto: do not abort after successful lookup

2017-09-01 Thread quark (Jun Wu)
quark accepted this revision. quark added a comment. LGTM. I have checked there are no other suspicious `_abort` in this file. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D608 To: spectral, #hg-reviewers, quark Cc: quark, mercurial-devel

D608: wireproto: do not abort after successful lookup

2017-09-01 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As far as I can tell, this interface originally used 'return' here, so the "fallthrough" to self._abort made sense. When it was switched to 'yield' this didn't