D6122: tests: add a file listing all the flaky tests

2019-06-12 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In D6122#89861 , @lothiraldan wrote: > In D6122#89819 , @av6 wrote: > >> In D6122#89818 , @lothiraldan wrote: >> >>>

D6122: tests: add a file listing all the flaky tests

2019-03-22 Thread lothiraldan (Boris Feld)
lothiraldan added a subscriber: durin42. lothiraldan added a comment. In https://phab.mercurial-scm.org/D6122#89819, @av6 wrote: > In https://phab.mercurial-scm.org/D6122#89818, @lothiraldan wrote: > > > @av6 is a `--no-flaky-tests` flag what you had in mind? > > > Something

D6122: tests: add a file listing all the flaky tests

2019-03-21 Thread av6 (Anton Shestakov)
av6 added a comment. In https://phab.mercurial-scm.org/D6122#89818, @lothiraldan wrote: > @av6 is a `--no-flaky-tests` flag what you had in mind? Something like that, yes. I suggested that flag seeing how this change introduces a quite specific file with just one line. And I

D6122: tests: add a file listing all the flaky tests

2019-03-21 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. The big difference between `#require slow` and `#require flaky` is that we don't want to run the slow tests by default but we want to run the flaky test by default if not specified otherwise. I don't know enough about the test runner to evaluate the amount of

D6122: tests: add a file listing all the flaky tests

2019-03-12 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D6122#89169, @av6 wrote: > Another way to do this could be to introduce another special keyword, similar to "slow", so that tests that are known flaky can `#require flaky` or even mark a specific block with `#if flaky`.

D6122: tests: add a file listing all the flaky tests

2019-03-12 Thread av6 (Anton Shestakov)
av6 added a comment. Another way to do this could be to introduce another special keyword, similar to "slow", so that tests that are known flaky can `#require flaky` or even mark a specific block with `#if flaky`. Obviously fixing ​test-remotefilelog-bgprefetch.t is a better idea

D6122: tests: add a file listing all the flaky tests

2019-03-12 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This file can be used by CI instances to skip tests known to be flaky and focus on tests with no false negatives. REPOSITORY rHG Mercurial REVISION DETAIL