D6123: ZeroDivisionError: Add condition to avoid Zerodivisonerror due to float number (issue6099)

2019-03-13 Thread akshjain.jain74 (Akshit Jain)
akshjain.jain74 added a comment. actually i am not getting what can be the proper topic for this :( REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6123 To: akshjain.jain74, durin42, #hg-reviewers Cc: av6, pulkit, mercurial-devel

D6123: ZeroDivisionError: Add condition to avoid Zerodivisonerror due to float number (issue6099)

2019-03-13 Thread akshjain.jain74 (Akshit Jain)
akshjain.jain74 added a comment. sorry for that , but can you tell me in what condition this function will return none value? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6123 To: akshjain.jain74, durin42, #hg-reviewers Cc: av6, pulkit, mercurial-devel

D6123: ZeroDivisionError: Add condition to avoid Zerodivisonerror due to float number (issue6099)

2019-03-13 Thread av6 (Anton Shestakov)
av6 added a comment. Okay, let's go over #1 in https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist once more. If you want to know what a good "topic" is, look at what other people do. How patches that get accepted generally look. How bug-fixing commits are worded.

D6123: ZeroDivisionError: Add condition to avoid Zerodivisonerror due to float number (issue6099)

2019-03-13 Thread akshjain.jain74 (Akshit Jain)
akshjain.jain74 updated this revision to Diff 14482. akshjain.jain74 retitled this revision from "Experimental features: Add condition to for float number (issue6099)" to "ZeroDivisionError: Add condition to avoid Zerodivisonerror due to float number (issue6099)". REPOSITORY rHG Mercurial