This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3bdb21bbf791: rust-dagops: range of revisions (authored by
gracinet, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D6229?vs=14740&id=14850#toc
REPOSITORY
rHG Mercurial
CHAN
gracinet added a comment.
@kevincox, thanks for the review, updated version available.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6229
To: gracinet, #hg-reviewers, kevincox
Cc: durin42, kevincox, mjpieters, mercurial-devel
___
gracinet updated this revision to Diff 14740.
gracinet marked 2 inline comments as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6229?vs=14718&id=14740
REVISION DETAIL
https://phab.mercurial-scm.org/D6229
AFFECTED FILES
rust/hg-core/src/dagops.
gracinet marked 2 inline comments as done.
gracinet added inline comments.
INLINE COMMENTS
> kevincox wrote in dagops.rs:140
> Can you use:
>
> for rev in heads_ancestors.into_iter().rev() {
> // ...
> }
Ah yes, thanks, I've been looking for something like that on
`DoubleEndedIterator
kevincox accepted this revision.
kevincox added inline comments.
INLINE COMMENTS
> dagops.rs:140
> +let l = heads_ancestors.len();
> +for i in 1..=l {
> +let rev = heads_ancestors[l - i];
Can you use:
for rev in heads_ancestors.into_iter().rev() {
// ...
}
> dagops.rs:
gracinet created this revision.
Herald added subscribers: mercurial-devel, mjpieters, kevincox, durin42.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a Rust implementation for what reachableroots2() does if
includepath is True.
The algorithmic details and performance no
