This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd09bdb2a1f75: rust-discovery: core implementation for
take_quick_sample() (authored by gracinet, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D6257?vs=15021&id=15145#toc
REPO
gracinet added a comment.
@kevincox thanks for the initial review, I think I've implemented the
corrections you suggested.
INLINE COMMENTS
> kevincox wrote in discovery.rs:70
> You can do
>
> if see.insert(current).is_some() {
> continue; // Already present.
> }
>
> And avoid the i
gracinet updated this revision to Diff 15021.
gracinet marked 2 inline comments as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6257?vs=14796&id=15021
REVISION DETAIL
https://phab.mercurial-scm.org/D6257
AFFECTED FILES
rust/hg-core/Cargo.toml
kevincox accepted this revision.
kevincox added inline comments.
INLINE COMMENTS
> discovery.rs:70
> +};
> +if seen.contains(¤t) {
> +continue;
You can do
if see.insert(current).is_some() {
continue; // Already present.
}
And avoid the insert below. Alternat
gracinet updated this revision to Diff 14796.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6257?vs=14787&id=14796
REVISION DETAIL
https://phab.mercurial-scm.org/D6257
AFFECTED FILES
rust/hg-core/Cargo.toml
rust/hg-core/src/discovery.rs
CHANGE DET
gracinet created this revision.
Herald added subscribers: mercurial-devel, kevincox, durin42.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This makes in particular `rand` no longer a testing dependency.
We keep a seedable random generator on the `PartialDiscovery` object
itself
