Re: D6282: branch: abort if closing branch from a non-branchhead cset

2019-05-17 Thread Sushil Khanchi
I am +1 with adding the `--force` option to override the abort as it seems the better option than 1) warning message (as it would change the repo anyway) 2) adding a message in commit editor. (hard to notice) I will send a patch for it. Let me know if you have a different opinion on this :-) On

Re: D6282: branch: abort if closing branch from a non-branchhead cset

2019-05-08 Thread Matt Harbison
On Sun, 05 May 2019 14:13:16 -0400, Pierre-Yves David wrote: On 5/1/19 11:18 PM, Sushil Khanchi wrote: . On Wed, May 1, 2019 at 9:22 PM Pierre-Yves David > wrote: . On 5/1/19 2:14 PM, Sushil Khanchi wrote: > . > > On Wed,

Re: D6282: branch: abort if closing branch from a non-branchhead cset

2019-05-05 Thread Pierre-Yves David
On 5/1/19 11:18 PM, Sushil Khanchi wrote: . On Wed, May 1, 2019 at 9:22 PM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: . On 5/1/19 2:14 PM, Sushil Khanchi wrote: > . > > On Wed, May 1, 2019 at 5:14 PM Pierre-Yves David >

Re: D6282: branch: abort if closing branch from a non-branchhead cset

2019-05-01 Thread Sushil Khanchi
. On Wed, May 1, 2019 at 9:22 PM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > . > > On 5/1/19 2:14 PM, Sushil Khanchi wrote: > > . > > > > On Wed, May 1, 2019 at 5:14 PM Pierre-Yves David > > mailto:pierre-yves.da...@ens-lyon.org>> > > > wrote: > > > > > > > > On 5/1/19 1:14

Re: D6282: branch: abort if closing branch from a non-branchhead cset

2019-05-01 Thread Pierre-Yves David
. On 5/1/19 2:14 PM, Sushil Khanchi wrote: . On Wed, May 1, 2019 at 5:14 PM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 5/1/19 1:14 PM, Sushil Khanchi wrote: > . > > On Fri, Apr 26, 2019 at 8:29 PM Pierre-Yves David >

Re: D6282: branch: abort if closing branch from a non-branchhead cset

2019-05-01 Thread Sushil Khanchi
. On Wed, May 1, 2019 at 5:14 PM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 5/1/19 1:14 PM, Sushil Khanchi wrote: > > . > > > > On Fri, Apr 26, 2019 at 8:29 PM Pierre-Yves David > > mailto:pierre-yves.da...@ens-lyon.org>> > > > wrote: > > > > > > > > On 4/19/19 9:49

Re: D6282: branch: abort if closing branch from a non-branchhead cset

2019-05-01 Thread Pierre-Yves David
On 5/1/19 1:14 PM, Sushil Khanchi wrote: . On Fri, Apr 26, 2019 at 8:29 PM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 4/19/19 9:49 AM, khanchi97 (Sushil khanchi) wrote: > khanchi97 created this revision. > Herald added a subscriber:

Re: D6282: branch: abort if closing branch from a non-branchhead cset

2019-05-01 Thread Sushil Khanchi
. On Fri, Apr 26, 2019 at 8:29 PM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 4/19/19 9:49 AM, khanchi97 (Sushil khanchi) wrote: > > khanchi97 created this revision. > > Herald added a subscriber: mercurial-devel. > > Herald added a reviewer: hg-reviewers. > > > >

Re: D6282: branch: abort if closing branch from a non-branchhead cset

2019-04-26 Thread Pierre-Yves David
On 4/19/19 9:49 AM, khanchi97 (Sushil khanchi) wrote: khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch make sure that we abort if the user is trying to close a branch from a cset which is not

D6282: branch: abort if closing branch from a non-branchhead cset

2019-04-25 Thread khanchi97 (Sushil khanchi)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8d14d91584f1: branch: abort if closing branch from a non-branchhead cset (authored by khanchi97, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6282: branch: abort if closing branch from a non-branchhead cset

2019-04-19 Thread khanchi97 (Sushil khanchi)
khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch make sure that we abort if the user is trying to close a branch from a cset which is not a branch head. Changes in test file reflect the fixed