D6393: rust-dirstate: add "dirs" Rust implementation

yuja added a comment. > +impl DirsMultiset { > +/// Initializes the multiset from a dirstate or a manifest. > +/// > +/// If `skip_state` is provided, skips dirstate entries with equal state. > +pub fn new(iterable: DirsIterable, skip_state: Option) -> Self { > +

Re: D6393: rust-dirstate: add "dirs" Rust implementation

> +impl DirsMultiset { > +/// Initializes the multiset from a dirstate or a manifest. > +/// > +/// If `skip_state` is provided, skips dirstate entries with equal state. > +pub fn new(iterable: DirsIterable, skip_state: Option) -> Self { > +let mut multiset = DirsMultiset {

D6393: rust-dirstate: add "dirs" Rust implementation

Closed by commit rHG2dcee6497b0b: rust-dirstate: add dirs Rust implementation (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D6393: rust-dirstate: add "dirs" Rust implementation

kevincox added inline comments. INLINE COMMENTS > martinvonz wrote in dirs_multiset.rs:43 > Maybe Kevin meant something like this? > > if skip_state == None | skip_state == Some(state) { > multiset.add_path(filename); > } No, you are right. I misread the condition. REPOSITORY rHG

D6393: rust-dirstate: add "dirs" Rust implementation

martinvonz added inline comments. INLINE COMMENTS > Alphare wrote in dirs_multiset.rs:43 > Unless I'm missing something, this would render the `if` statement useless. Maybe Kevin meant something like this? if skip_state == None | skip_state == Some(state) { multiset.add_path(filename);

D6393: rust-dirstate: add "dirs" Rust implementation

Alphare added a comment. In D6393#95768 , @kevincox wrote: > Sorry. I was busy. In general don't worry about blocking on me, I can't promise any sort of reasonable response time. Worst case I can review the changes after submission and changes

D6393: rust-dirstate: add "dirs" Rust implementation

Alphare marked an inline comment as done. Alphare updated this revision to Diff 15670. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6393?vs=15508=15670 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6393/new/ REVISION DETAIL

D6393: rust-dirstate: add "dirs" Rust implementation

kevincox added a comment. kevincox accepted this revision. Sorry. I was busy. In general don't worry about blocking on me, I can't promise any sort of reasonable response time. Worst case I can review the changes after submission and changes can be made afterwards. INLINE COMMENTS >

D6393: rust-dirstate: add "dirs" Rust implementation

Alphare added a comment. @kevincox, do you have any comments about this change? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6393/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6393 To: Alphare, #hg-reviewers Cc: martinvonz, durin42,

D6393: rust-dirstate: add "dirs" Rust implementation

Alphare updated this revision to Diff 15508. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6393?vs=15341=15508 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6393/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6393 AFFECTED FILES

D6393: rust-dirstate: add "dirs" Rust implementation

Alphare updated this revision to Diff 15341. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6393?vs=15160=15341 REVISION DETAIL https://phab.mercurial-scm.org/D6393 AFFECTED FILES rust/hg-core/src/dirstate/dirs_multiset.rs

D6393: rust-dirstate: add "dirs" Rust implementation

Alphare added a comment. In https://phab.mercurial-scm.org/D6393#94007, @martinvonz wrote: > Does this need updating after https://phab.mercurial-scm.org/D6403? Based on a cursory look at the patch, it has not been updated yet. Indeed it did. I've updated this changeset and

D6393: rust-dirstate: add "dirs" Rust implementation

martinvonz added a comment. Does this need updating after https://phab.mercurial-scm.org/D6403? Based on a cursory look at the patch, it has not been updated yet. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6393 To: Alphare, #hg-reviewers Cc: martinvonz,

D6393: rust-dirstate: add "dirs" Rust implementation

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Following the work done in https://phab.mercurial-scm.org/rHGd1786c1d34fa927d4048054ebe62c55fa14f9b1e and working towards the goal of a