Closed by commit rHG8041a1b45163: rust-discovery: takefullsample() core
implementation (authored by gracinet).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
REPOSITORY
rHG Mercurial
Alphare updated this revision to Diff 16012.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6424?vs=15934=16012
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6424/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6424
AFFECTED FILES
Alphare updated this revision to Diff 15934.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6424?vs=15482=15934
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6424/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6424
AFFECTED FILES
gracinet updated this revision to Diff 15482.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6424?vs=15223=15482
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6424/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6424
AFFECTED FILES
kevincox accepted this revision.
kevincox added inline comments.
INLINE COMMENTS
> discovery.rs:124
> +fn next( self) -> Option {
> +if self.cur > 1 {
> +return None;
I think it would be nice to remove the magic number.
if self.cur >= self.parents.len()
REPOSITORY
gracinet added a comment.
@kevincox this used to be https://phab.mercurial-scm.org/D6260 (I don't
think I changed anything besides rebasing)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6424
To: gracinet, #hg-reviewers
Cc: durin42, kevincox, mercurial-devel
gracinet created this revision.
Herald added subscribers: mercurial-devel, kevincox, durin42.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
take_full_sample() browses the undecided set in both directions: from
its roots as well as from its heads.
Following what's done on the
