D648: blackbox: fix rotation with chg

2017-09-12 Thread quark (Jun Wu)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4f60720cf0df: blackbox: fix rotation with chg (authored by quark). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D648?vs=1651=1750#toc REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D648: blackbox: fix rotation with chg

2017-09-12 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. > I think the original patch was trying to make different `ui` objects use a same file object if their `blackbox.log` path is the same. In theory it could also be problematic in the rotation

D648: blackbox: fix rotation with chg

2017-09-07 Thread quark (Jun Wu)
quark added a comment. I think the original patch was trying to make different `ui` objects use a same file object if their `blackbox.log` path is the same. In theory it could also be problematic in the rotation case. Anyway, that becomes necessary after https://phab.mercurial-scm.org/D650.

D648: blackbox: fix rotation with chg

2017-09-07 Thread durham (Durham Goode)
durham added a comment. This seems like mostly a revert of the original commit. timeless might have to chime in here, since it's not clear exactly what issue the original patch was fixing. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D648 To: quark,

D648: blackbox: fix rotation with chg

2017-09-06 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The added test will show: $ $PYTHON showsize.py .hg/blackbox* .hg/blackbox.log: < 500 .hg/blackbox.log.1: < 500 .hg/blackbox.log.2: < 500