D6553: shelve: move shelve extension to core

navaneeth.suresh added inline comments. navaneeth.suresh marked an inline comment as done. INLINE COMMENTS > pulkit wrote in commands.py:6207 > I just noticed that the function `_dounshelve()` still has `_` prefix. We > generally have that to mark if functions are local to that file or class.

D6553: shelve: move shelve extension to core

pulkit added inline comments. INLINE COMMENTS > commands.py:6207 > +with repo.wlock(): > +return shelvemod._dounshelve(ui, repo, *shelved, **opts) > + I just noticed that the function `_dounshelve()` still has `_` prefix. We generally have that to mark if functions are local to

D6553: shelve: move shelve extension to core

navaneeth.suresh added a comment. In D6553#96119 , @yuja wrote: > Need to update `extensions._builtin` so the shelve "extension" is silently > ignored. > Please send a follow up. Doing that right away! Thanks @yuja! REPOSITORY rHG

D6553: shelve: move shelve extension to core

yuja added a comment. Need to update `extensions._builtin` so the shelve "extension" is silently ignored. Please send a follow up. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6553/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6553

Re: D6553: shelve: move shelve extension to core

Need to update `extensions._builtin` so the shelve "extension" is silently ignored. Please send a follow up. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D6553: shelve: move shelve extension to core

Closed by commit rHG46087aeb8ae2: shelve: move shelve extension to core (authored by navaneeth.suresh). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D6553?vs=15701=15707#toc REPOSITORY rHG Mercurial CHANGES

D6553: shelve: move shelve extension to core

navaneeth.suresh marked an inline comment as done. navaneeth.suresh updated this revision to Diff 15701. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6553?vs=15700=15701 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6553/new/ REVISION

D6553: shelve: move shelve extension to core

navaneeth.suresh added a comment. @pulkit Changes have been made. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6553/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6553 To: navaneeth.suresh, #hg-reviewers, pulkit Cc: martinvonz, pulkit,

D6553: shelve: move shelve extension to core

navaneeth.suresh edited the summary of this revision. navaneeth.suresh updated this revision to Diff 15700. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6553?vs=15692=15700 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6553/new/ REVISION

D6553: shelve: move shelve extension to core

navaneeth.suresh added inline comments. INLINE COMMENTS > martinvonz wrote in shelve.py:296-304 > This doesn't seem right. It seems D3693 > just forgot to delete `clearstatus()`. > Could you send a patch before this one to do that? Doing that right away!

D6553: shelve: move shelve extension to core

martinvonz added inline comments. INLINE COMMENTS > shelve.py:296-304 > +# duplicate of rebase.clearstatus to avoid importing rebase > +def clearstatus(repo): > +'Remove the status files' > +# Make sure the active transaction won't write the state file > +tr =

D6553: shelve: move shelve extension to core

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. Thanks a lot for working on this. This needs to be rebased on tip of default branch. Also, can you add an entry about shelve extension being moved to core in relnotes/next file.

D6553: shelve: move shelve extension to core

navaneeth.suresh added inline comments. INLINE COMMENTS > pulkit wrote in shelve.py:643 > We don't import things from hgext in mercurial. I am not sure why. > > I think it will be fine to duplicate clearstatus() from rebase to shelve.py > for the movement and add a comment that it's copied.

D6553: shelve: move shelve extension to core

navaneeth.suresh marked an inline comment as done. navaneeth.suresh updated this revision to Diff 15692. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6553?vs=15634=15692 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6553/new/ REVISION

D6553: shelve: move shelve extension to core

pulkit added inline comments. INLINE COMMENTS > shelve.py:643 > + > +from hgext import rebase > rebase.clearstatus(repo) We don't import things from hgext in mercurial. I am not sure why. I think it will be fine to duplicate clearstatus() from rebase to

D6553: shelve: move shelve extension to core

navaneeth.suresh updated this revision to Diff 15634. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6553?vs=15621=15634 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6553/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6553

D6553: shelve: move shelve extension to core

navaneeth.suresh added a comment. @Kwan Thanks for the review. I have updated the patch as you suggested. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6553/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6553 To: navaneeth.suresh,

D6553: shelve: move shelve extension to core

Kwan added a comment. You should probably run `hg mv -A hgext/shelve.py mercurial/shelve.py` and amend and re-send to preserve history. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6553/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6553

D6553: shelve: move shelve extension to core

navaneeth.suresh updated this revision to Diff 15621. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6553?vs=15616=15621 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6553/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6553

D6553: shelve: move shelve extension to core

navaneeth.suresh created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Until now,`shelve` was bootstrapped as an extension. This patch adds `shelve` on core. REPOSITORY rHG Mercurial REVISION DETAIL