D6555: vfs: require use of .seek() or .write() before .tell() on append-mode files

2019-06-20 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. I worked around the same bug in Windows in platform.posixfile [1]. Should this be done in the posix layer (which is currently only an alias to `open()`)? It looks like there are uses of posixfile outside of vfs. [1]

D6555: vfs: require use of .seek() or .write() before .tell() on append-mode files

2019-06-20 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This prevents the bug in the previous change, but avoids an extraneous seek() call in the common case when it's not required. My preference was to ban .seek()