D6594: RFC dirstatemap

Alphare added a comment. I have updated and split this RFC into a new series (https://phab.mercurial-scm.org/D6625, see the Stack tab). This differential can be considered outdated. @kevincox: I will try my best to take into account the comments you've already left here after the new

D6594: RFC dirstatemap

kevincox added a comment. In D6594#96518 , @yuja wrote: > Yes, so we'll probably want to minimize the data exchanged between Rust > and Python. This means we'll eventually move more logic to Rust side, which > hopefully reduce the number of

Re: D6594: RFC dirstatemap

> On Jul 8, 2019, at 10:12, Yuya Nishihara wrote: > >>> I heard boxing a PyObject has measurable cost, >> >> Do you have a link to any benchmarks? I'd be interested. > > No number. IIRC, Augie tried to implement a parser by using nom, which > was breezing fast, until converting parsed

D6594: RFC dirstatemap

yuja added a comment. > > I heard boxing a PyObject has measurable cost, > Do you have a link to any benchmarks? I'd be interested. No number. IIRC, Augie tried to implement a parser by using nom, which was breezing fast, until converting parsed result back to PyObjects. I think

Re: D6594: RFC dirstatemap

> > I heard boxing a PyObject has measurable cost, > > Do you have a link to any benchmarks? I'd be interested. No number. IIRC, Augie tried to implement a parser by using nom, which was breezing fast, until converting parsed result back to PyObjects. I think we also have some cached

Re: D6594: RFC dirstatemap

On 7/7/19 3:45 PM, Yuya Nishihara wrote: sharing references between Rust and Python: https://raphaelgomes.dev/blog/articles/2019-07-01-sharing-references-between-python-and-rust.html. Do you have some benchmark number compared to simpler (and dumb) approaches such as caching PyList/Dict

D6594: RFC dirstatemap

Alphare added a comment. Alphare marked 4 inline comments as done. > Do you have some benchmark number compared to simpler (and dumb) approaches > such as caching PyList/Dict representation? I don't have any benchmarks as of yet, sorry. > I heard boxing a PyObject has measurable

D6594: RFC dirstatemap

yuja added a comment. > sharing references between Rust and Python: > https://raphaelgomes.dev/blog/articles/2019-07-01-sharing-references-between-python-and-rust.html. Do you have some benchmark number compared to simpler (and dumb) approaches such as caching PyList/Dict

Re: D6594: RFC dirstatemap

> sharing references between Rust and Python: > https://raphaelgomes.dev/blog/articles/2019-07-01-sharing-references-between-python-and-rust.html. Do you have some benchmark number compared to simpler (and dumb) approaches such as caching PyList/Dict representation? I heard boxing a PyObject has

D6594: RFC dirstatemap

kevincox added inline comments. INLINE COMMENTS > dirstate_map.rs:47 > + > +impl Default for DirstateMap { > +fn default() -> Self { Can you just `#[derive(Default)]`? > dirstate_map.rs:95 > +filename: &[u8], > +old_state: u8, > +entry: DirstateEntry, This should

D6594: RFC dirstatemap

Alphare added a comment. If that helps, I just wrote an article on sharing references between Rust and Python: https://raphaelgomes.dev/blog/articles/2019-07-01-sharing-references-between-python-and-rust.html. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION