Closed by commit rHGc36bdb4e884d: rust-parsers: switch to parse/pack_dirstate
to mutate-on-loop (authored by Alphare).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
REPOSITORY
rHG
Alphare updated this revision to Diff 16046.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6628?vs=15897=16046
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6628/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6628
AFFECTED FILES
kevincox added inline comments.
kevincox accepted this revision.
INLINE COMMENTS
> mod.rs:16
> +pub p1: Vec,
> +pub p2: Vec,
> }
If these are always 20 bytes long you are best to use `[u8; 20]`. That way
there will be no indirection. And since `Vec` is 3 words it will have a bigger
Alphare updated this revision to Diff 15897.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6628?vs=15841=15897
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6628/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6628
AFFECTED FILES
Alphare created this revision.
Herald added subscribers: mercurial-devel, mjpieters, kevincox, durin42.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Both `parse_dirstate` and `pack_dirstate` can operate directly on the data
they're passed, which prevents the creation of
